Bug 82149 - Split MediaList into internal and CSSOM types
: Split MediaList into internal and CSSOM types
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: CSS
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 77745
  Show dependency treegraph
 
Reported: 2012-03-25 11:17 PDT by Antti Koivisto
Modified: 2012-04-11 20:54 PDT (History)
5 users (show)

See Also:


Attachments
patch (53.49 KB, patch)
2012-03-25 11:32 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
rebased (54.64 KB, patch)
2012-03-25 15:23 PDT, Antti Koivisto
webkit.review.bot: commit‑queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (9.75 MB, application/zip)
2012-03-25 15:58 PDT, WebKit Review Bot
no flags Details
don't change spacing of cssText output (54.61 KB, patch)
2012-03-25 16:19 PDT, Antti Koivisto
akling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-03-25 11:17:24 PDT
MediaList is a CSSOM type and should not be used internally.
Comment 1 Antti Koivisto 2012-03-25 11:32:48 PDT
Created attachment 133684 [details]
patch
Comment 2 WebKit Review Bot 2012-03-25 11:36:09 PDT
Attachment 133684 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/MediaList.h:80:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2012-03-25 15:23:30 PDT
Created attachment 133694 [details]
rebased
Comment 4 WebKit Review Bot 2012-03-25 15:26:30 PDT
Attachment 133694 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/MediaList.h:80:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Review Bot 2012-03-25 15:58:43 PDT
Comment on attachment 133694 [details]
rebased

Attachment 133694 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12127555

New failing tests:
fast/dom/css-dom-read-2.html
fast/css/insertRule-media.html
Comment 6 WebKit Review Bot 2012-03-25 15:58:50 PDT
Created attachment 133697 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 Antti Koivisto 2012-03-25 16:19:10 PDT
Created attachment 133698 [details]
don't change spacing of cssText output
Comment 8 WebKit Review Bot 2012-03-25 16:22:56 PDT
Attachment 133698 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/MediaList.h:80:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Andreas Kling 2012-03-26 01:40:07 PDT
Comment on attachment 133698 [details]
don't change spacing of cssText output

View in context: https://bugs.webkit.org/attachment.cgi?id=133698&action=review

r=me.

> Source/WebCore/ChangeLog:115
> +            Move the media query ownershit to CSSStyleSheet where it belongs.

Accidental(?) typo: ownership. :)
Comment 10 Antti Koivisto 2012-03-26 04:52:56 PDT
trac.webkit.org/changeset/112076