Bug 82149 - Split MediaList into internal and CSSOM types
: Split MediaList into internal and CSSOM types
Status: RESOLVED FIXED
: WebKit
CSS
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 77745
  Show dependency treegraph
 
Reported: 2012-03-25 11:17 PST by
Modified: 2012-04-11 20:54 PST (History)


Attachments
patch (53.49 KB, patch)
2012-03-25 11:32 PST, Antti Koivisto
no flags Review Patch | Details | Formatted Diff | Diff
rebased (54.64 KB, patch)
2012-03-25 15:23 PST, Antti Koivisto
webkit.review.bot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (9.75 MB, application/zip)
2012-03-25 15:58 PST, WebKit Review Bot
no flags Details
don't change spacing of cssText output (54.61 KB, patch)
2012-03-25 16:19 PST, Antti Koivisto
akling: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-03-25 11:17:24 PST
MediaList is a CSSOM type and should not be used internally.
------- Comment #1 From 2012-03-25 11:32:48 PST -------
Created an attachment (id=133684) [details]
patch
------- Comment #2 From 2012-03-25 11:36:09 PST -------
Attachment 133684 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/MediaList.h:80:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2012-03-25 15:23:30 PST -------
Created an attachment (id=133694) [details]
rebased
------- Comment #4 From 2012-03-25 15:26:30 PST -------
Attachment 133694 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/MediaList.h:80:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #5 From 2012-03-25 15:58:43 PST -------
(From update of attachment 133694 [details])
Attachment 133694 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12127555

New failing tests:
fast/dom/css-dom-read-2.html
fast/css/insertRule-media.html
------- Comment #6 From 2012-03-25 15:58:50 PST -------
Created an attachment (id=133697) [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
------- Comment #7 From 2012-03-25 16:19:10 PST -------
Created an attachment (id=133698) [details]
don't change spacing of cssText output
------- Comment #8 From 2012-03-25 16:22:56 PST -------
Attachment 133698 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/MediaList.h:80:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #9 From 2012-03-26 01:40:07 PST -------
(From update of attachment 133698 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=133698&action=review

r=me.

> Source/WebCore/ChangeLog:115
> +            Move the media query ownershit to CSSStyleSheet where it belongs.

Accidental(?) typo: ownership. :)
------- Comment #10 From 2012-03-26 04:52:56 PST -------
trac.webkit.org/changeset/112076