Bug 82148 - Remove duplicated GenerateConditionalString() from code generators
Summary: Remove duplicated GenerateConditionalString() from code generators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-25 10:28 PDT by Kentaro Hara
Modified: 2012-03-25 13:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (30.86 KB, patch)
2012-03-25 10:30 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-03-25 10:28:45 PDT
GenerateConditionalString()s are defined in each code generator, and they are doing the same thing. We should put GenerateConditionalString() in CodeGenerator.pm and remove duplicated code.
Comment 1 Kentaro Hara 2012-03-25 10:30:49 PDT
Created attachment 133683 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-25 13:00:21 PDT
Comment on attachment 133683 [details]
Patch

Clearing flags on attachment: 133683

Committed r112036: <http://trac.webkit.org/changeset/112036>
Comment 3 WebKit Review Bot 2012-03-25 13:00:25 PDT
All reviewed patches have been landed.  Closing bug.