CSSMediaRule, WebKitCSSKeyframesRule and WebKitRegionRule use CSSRuleList for storing children. They should use a simple rule vector instead. CSSRuleList is a CSSOM type that should be instantiated on demand for API purposes only.
Created attachment 133636 [details] patch
Attachment 133636 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/css/CSSRuleList.h:37: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 133636 [details] patch Attachment 133636 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12132098 New failing tests: http/tests/security/cannot-read-cssrules.html http/tests/security/cannot-read-cssrules-redirect.html
Created attachment 133640 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 133641 [details] security check CSSStyleSheet.rules too
Attachment 133641 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/css/CSSRuleList.h:37: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 133643 [details] more correct ChangeLog
Attachment 133643 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/css/CSSRuleList.h:37: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 133643 [details] more correct ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=133643&action=review r=me > Source/WebCore/css/CSSMediaRule.cpp:124 > + result.append(" "); Since we are touching this, we should also change " " to ' '. Same comment repeated for other applicable lines.
http://trac.webkit.org/changeset/112037
...and the test update in http://trac.webkit.org/changeset/112038