Bug 82124 - Media controls rendering regression
Summary: Media controls rendering regression
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on: 82125 82150 82476 82515 82626 85990 87591
Blocks: 79347
  Show dependency treegraph
Reported: 2012-03-24 02:09 PDT by Victor Carbune
Modified: 2012-05-27 08:52 PDT (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Victor Carbune 2012-03-24 02:09:44 PDT
Bug 79746 introduced a regressions when displaying media controls.
I'm providing explanations and a quick fix and I'm working on solving them properly:

Controls are displayed on full-screen (http://code.google.com/p/chromium/issues/detail?id=119527):
In Bug79746 I have introduced a timer to set display:none on controls after the fade out transition ends (the reasons are explained in the ChangeLog). Before this change, the display property was used only in the logic above the PanelElement to set controls permanently displayed or not. The media control panel, however, should be aware of the state when toggling the display property. 

Volume slider is displayed below the volume box (http://code.google.com/p/chromium/issues/detail?id=119651):
This is also caused of toggling the display:none property. The current rendering of slider container contains logic offset in RenderMediaVolumeSliderContainer::layout() which isn't always called again when the display property is toggled.