Notifications should be in Modules/notifications
Created attachment 133624 [details] Patch
Comment on attachment 133624 [details] Patch Attachment 133624 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12128047
Comment on attachment 133624 [details] Patch Attachment 133624 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12123964
Comment on attachment 133624 [details] Patch Attachment 133624 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12131011
Comment on attachment 133624 [details] Patch Attachment 133624 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12132003
Comment on attachment 133624 [details] Patch Attachment 133624 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12131010
Comment on attachment 133624 [details] Patch Attachment 133624 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12131013
The diff is screwed up somehow. I think because I'm adding the whole directory? /me is confused.
Comment on attachment 133624 [details] Patch Attachment 133624 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12123962
Comment on attachment 133624 [details] Patch I need to make a version of this patch that, you know, compiles.
Created attachment 148488 [details] Patch for EFL and GTK port Hello Adam, I wonder whether you will submit modified patch. Anyway, to help you, I make a patch for EFL and GTK ports. However, if you are busy to make this patch again, I would like to submit a patch in order to support all ports.
Thank you. I've gotten distracted by other patches. If you work up a patch here, I'd be happy to review it.
Created attachment 148501 [details] Patch for EFL ,GTK and QT port Thank you for your consideration. This patch is for EFL, GTK and QT ports for now. I'm gonna submit a patch which supports Chromium, Mac and Win ports as well.
Comment on attachment 148501 [details] Patch for EFL ,GTK and QT port Attachment 148501 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13007092
Comment on attachment 148501 [details] Patch for EFL ,GTK and QT port Attachment 148501 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13002101
Comment on attachment 148501 [details] Patch for EFL ,GTK and QT port Attachment 148501 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13008095
Created attachment 148614 [details] Patch
Comment on attachment 148614 [details] Patch Attachment 148614 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13005271
Comment on attachment 148614 [details] Patch Attachment 148614 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12998322
Comment on attachment 148614 [details] Patch This doesn't appear to build on mac or win.
Created attachment 150603 [details] Patch
This patch is for all ports except for win port. I'm still working on win port as well.
Comment on attachment 150603 [details] Patch Attachment 150603 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13139175
Created attachment 150747 [details] Patch
Comment on attachment 150747 [details] Patch Thanks for doing this!
Comment on attachment 150747 [details] Patch Clearing flags on attachment: 150747 Committed r121882: <http://trac.webkit.org/changeset/121882>
All reviewed patches have been landed. Closing bug.
I pointed DerivedSource.make to the new location for notifications idl files in <http://trac.webkit.org/changeset/122036>.
(In reply to comment #28) > I pointed DerivedSource.make to the new location for notifications idl files in <http://trac.webkit.org/changeset/122036>. I'm sorry. I missed it. Thanks.