Bug 82118 – [chromium] Incorrect replica originTransform used in CCDamageTracker

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Shawn Singh]

On Dana's patch in https://bugs.webkit.org/show_bug.cgi?id=81296,  we forgot to change on spot in the damage tracker code.  Its also my mistake for unofficially reviewing and not catching this.  Patch coming in a moment.   btw, 100% credit goes to Dana for finding this. =)

[Shawn Singh]

Created attachment 133621 [details]
Patch

[Dana Jansens]

Comment on attachment 133621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133621&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp:300
> +        TransformationMatrix replicaOriginTransform = renderSurface->replicaOriginTransform();

const reference?

[Shawn Singh]

Created attachment 133622 [details]
const reference. thanks Dana\!

[Adrienne Walker]

Comment on attachment 133622 [details]
const reference. thanks Dana\!

Good catch!

[WebKit Review Bot]

Comment on attachment 133622 [details]
const reference. thanks Dana\!

Clearing flags on attachment: 133622

Committed r111982: <http://trac.webkit.org/changeset/111982>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Shawn Singh]

There's no need to revert, but I'm re-opening this because one of the comments is wrong and I need to fix it.  (the unit test is not reflecting about left edge anchored to right side.  Its actually just ensuring that the anchor did not incorrectly affect the reflection.)

[Shawn Singh]

Created attachment 135396 [details]
Patch

[Adrienne Walker]

Comment on attachment 135396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135396&action=review

Sure, R=me.  Can you open a new bug next time? Bugzilla does pretty poorly with multiple patches on the same bug.

> Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:809
> +    // https://bugs.webkit.org/show_bug.cgi?id=82118

No need to link to this bug here.  That's what git blame is for.

[Shawn Singh]

(In reply to comment #9)
> (From update of attachment 135396 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135396&action=review
> 
> Sure, R=me.  Can you open a new bug next time? Bugzilla does pretty poorly with multiple patches on the same bug.
> 
> > Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:809
> > +    // https://bugs.webkit.org/show_bug.cgi?id=82118
> 
> No need to link to this bug here.  That's what git blame is for.

OK sure - I'll land this one on this bug, just this time.  From then on I'll use separate bugs.

Thanks for the super quick review =)

[Shawn Singh]

Created attachment 135402 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 135402 [details]
Patch for landing

Clearing flags on attachment: 135402

Committed r113078: <http://trac.webkit.org/changeset/113078>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.