WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
82105
ContainerNode::parserInsertBefore should not call notifyChildInserted
https://bugs.webkit.org/show_bug.cgi?id=82105
Summary
ContainerNode::parserInsertBefore should not call notifyChildInserted
Vicki Pfau
Reported
2012-03-23 17:21:51 PDT
Much like how parserAddChild does not call notifyChildInserted, parserInsertBefore shouldn't either. notifyChildInserted asserts !eventDispatchForbidden(), which is not a guarantee when parserInsertBefore is called. forbidEventDispatch/allowEventDispatch pairs have been excluded from XMLErrors::insertErrorMessageBlock until this is fixed to ensure the assertions are not hit.
Attachments
Add attachment
proposed patch, testcase, etc.
Lucas Forschler
Comment 1
2019-02-06 09:03:47 PST
Mass moving XML DOM bugs to the "DOM" Component.
Ahmad Saleem
Comment 2
2022-09-16 23:46:24 PDT
https://github.com/WebKit/WebKit/blob/60dcab2dae6c8a40f0f926b9eedcff807cd33652/Source/WebCore/dom/ContainerNode.cpp#L550
does not have any mention of notifyChildInserted because it was deleted in this commit:
https://github.com/WebKit/WebKit/commit/34c2ef31e2d069ec715511fee4ed6fdf294d5198
Marking this as 'RESOLVED CONFIGURATION CHANGED'.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug