RESOLVED FIXED Bug 82099
Simplify setting loading state in DocumentLoader 
https://bugs.webkit.org/show_bug.cgi?id=82099
Summary Simplify setting loading state in DocumentLoader
Nate Chapin
Reported 2012-03-23 16:01:31 PDT
DocumentLoader::isLoading() just returns m_loading, but the logic for setting m_loading is circuitous to say the least. It gets set consistently by some functions (e.g., addSubresourceLoader), but it also is set by updateLoading(), which sets it based on FrameLoader::isLoading(), which is based on a bunch of different DocumentLoader functions. I've got a patch that greatly simplifies this logic that I will post shortly. Then again, I might be stepping on a landmine :)
Attachments
patch (9.96 KB, patch)
2012-03-23 16:26 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2012-03-23 16:26:34 PDT
Created attachment 133585 [details] patch
Adam Barth
Comment 2 2012-03-26 13:19:20 PDT
Comment on attachment 133585 [details] patch This looks great.
WebKit Review Bot
Comment 3 2012-03-26 13:34:18 PDT
Comment on attachment 133585 [details] patch Clearing flags on attachment: 133585 Committed r112144: <http://trac.webkit.org/changeset/112144>
WebKit Review Bot
Comment 4 2012-03-26 13:34:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.