Bug 82086 - [chromium] RenderSurfaceChromium remove dead function declarations
Summary: [chromium] RenderSurfaceChromium remove dead function declarations
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shawn Singh
Depends on:
Reported: 2012-03-23 13:54 PDT by Shawn Singh
Modified: 2012-04-03 12:24 PDT (History)
3 users (show)

See Also:

Patch (1.51 KB, patch)
2012-04-03 11:22 PDT, Shawn Singh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2012-03-23 13:54:40 PDT
grep comes up with no usage of RenderSurfaceChromium::prepareContentsTexture(), and there doesn't even seem to be an implementation.
The same seems to be true for releaseContentsTexture() and draw().
Linux builds successfully without these declarations; a git blame shows these were added (with actual implementations) on different occasions, but now those implementations no longer exist?

I think we can remove these 3 functions.  Please feel free to WontFix this bug if they are actually needed!
Comment 1 Shawn Singh 2012-04-03 11:22:36 PDT
Created attachment 135371 [details]
Comment 2 Shawn Singh 2012-04-03 11:23:15 PDT
James, please feel free to WontFix it, or let me know if there is any other related cleanup that could be done.
Comment 3 James Robinson 2012-04-03 11:26:08 PDT
Comment on attachment 135371 [details]

Yarr, these be some dead functions.  Walk the plank!
Comment 4 Shawn Singh 2012-04-03 11:27:00 PDT
Comment on attachment 135371 [details]

aye - thanks =)
Comment 5 WebKit Review Bot 2012-04-03 12:24:49 PDT
Comment on attachment 135371 [details]

Clearing flags on attachment: 135371

Committed r113070: <http://trac.webkit.org/changeset/113070>
Comment 6 WebKit Review Bot 2012-04-03 12:24:53 PDT
All reviewed patches have been landed.  Closing bug.