Bug 82079 – REGRESSION: editing/inserting/insert-bg-font.html fails on Lion

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

It seems like editing/inserting/insert-bg-font.html has been failing on Lion bots.

http://build.webkit.org/results/Lion%20Intel%20Release%20(Tests)/r111885%20(6782)/results.html

--- /Volumes/Data/slave/lion-intel-release-tests/build/layout-test-results/editing/inserting/insert-bg-font-expected.txt
+++ /Volumes/Data/slave/lion-intel-release-tests/build/layout-test-results/editing/inserting/insert-bg-font-actual.txt
@@ -1,5 +1,5 @@
 
-        <div id="dv" contenteditable=""><span style="background-color: lightgrey">lightgrey background<font color="blue">blue font color over lightgrey background</font></span> 
+        <div id="dv" contenteditable=""><span style="background-color: lightgrey">lightgrey&nbsp;background blue<font color="#0000ff">&nbsp;font color over lightgrey background</font></span> 
 <div><span style="background-color: lightgrey"><font color="blue">this should also be blue over lightgrey</font></span></div></div>
 
FYI, I can't reproduce this failure locally on my Snow Leopard machine.

[Ryosuke Niwa]

Oops, I menat Lion.

[Ryosuke Niwa]

Added a failing expectation in http://trac.webkit.org/changeset/111891.

Do you know when this started failing?

[Ryosuke Niwa]

(In reply to comment #3)
> Do you know when this started failing?

Unfortunately not. It's weird that this failure only occurs on Lion.

Lion is the first OS X release with autocorrect. Perhaps it’s kicking in during the test. I have not seen this failure earlier today when looking for “tests failing more than once on the Lion WebKit2 bots in a 40-50 revision range”, so I suspect it’s recent. Perhaps it’s a bot configuration issue involving autocorrect.

[Ryosuke Niwa]

(In reply to comment #5)
> Lion is the first OS X release with autocorrect. Perhaps it’s kicking in during the test. I have not seen this failure earlier today when looking for “tests failing more than once on the Lion WebKit2 bots in a 40-50 revision range”, so I suspect it’s recent. Perhaps it’s a bot configuration issue involving autocorrect.

Possible but I'm still surprised that the element moved from one place to another. Maybe auto-correction code is changing the selection in some undesirable fashion?

[Koji Ishii]

Created attachment 139500 [details]
Patch

[Ryosuke Niwa]

Thanks for the fix!

[Koji Ishii]

Comment on attachment 139500 [details]
Patch

Thanks for the review!

[WebKit Review Bot]

Comment on attachment 139500 [details]
Patch

Clearing flags on attachment: 139500

Committed r115700: <http://trac.webkit.org/changeset/115700>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.