Bug 82077 - RexExp constructor last match properties should not rely on previous ovector
Summary: RexExp constructor last match properties should not rely on previous ovector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-23 12:22 PDT by Gavin Barraclough
Modified: 2012-03-23 12:57 PDT (History)
0 users

See Also:

Attachments
Fix (40.96 KB, patch)
2012-03-23 12:28 PDT, Gavin Barraclough 		oliver: review+
Details | Formatted Diff | Diff
Fix (44.21 KB, patch)
2012-03-23 12:44 PDT, Gavin Barraclough 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-03-23 12:22:36 PDT 
This change simplifies matching, and will enable subpattern results to be fully lazily generated in the future.
Comment 1 Gavin Barraclough 2012-03-23 12:28:57 PDT 
Created attachment 133534 [details]
Fix

No overall performance impact (maybe 1% progression on v8-regexp, nothing significant overall).
Comment 2 Oliver Hunt 2012-03-23 12:37:51 PDT 
Comment on attachment 133534 [details]
Fix

r=me, but you need to add the files to all the other project files.
Comment 3 Gavin Barraclough 2012-03-23 12:44:41 PDT 
Created attachment 133538 [details]
Fix
Comment 4 Gavin Barraclough 2012-03-23 12:57:50 PDT 
Fixed in r111889