Bug 82062 - [chromium] Fix scrollbarLayerLostContext flaky test crash on 10.6
Summary: [chromium] Fix scrollbarLayerLostContext flaky test crash on 10.6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-23 09:36 PDT by Adrienne Walker
Modified: 2012-03-23 10:13 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.86 KB, patch)
2012-03-23 09:38 PDT, Adrienne Walker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-03-23 09:36:26 PDT
[chromium] Fix scrollbarLayerLostContext flaky test crash on 10.6
Comment 1 Adrienne Walker 2012-03-23 09:38:32 PDT
Created attachment 133503 [details]
Patch
Comment 2 Adrienne Walker 2012-03-23 09:39:13 PDT
Build error: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28dbg%29/builds/9074/steps/webkit_unit_tests/logs/stdio

This happens maybe 10-20% of the time.
Comment 3 James Robinson 2012-03-23 09:44:02 PDT
Comment on attachment 133503 [details]
Patch

R=me

We should really just #ifdef the scrollbar stuff out on mac, calling in to cocoa is not threadsafe.
Comment 4 Adrienne Walker 2012-03-23 09:46:38 PDT
(In reply to comment #3)
> (From update of attachment 133503 [details])
> R=me
> 
> We should really just #ifdef the scrollbar stuff out on mac, calling in to cocoa is not threadsafe.

I'll put up another patch to do that for platforms we don't support yet.  I already saw a Windows "my scrollbars are black when I flip this flag" bug.
Comment 5 WebKit Review Bot 2012-03-23 10:13:25 PDT
Comment on attachment 133503 [details]
Patch

Clearing flags on attachment: 133503

Committed r111875: <http://trac.webkit.org/changeset/111875>
Comment 6 WebKit Review Bot 2012-03-23 10:13:29 PDT
All reviewed patches have been landed.  Closing bug.