Created attachment 133496 [details] accel comp updates Attached patch includes updates to the accelerated compositing code for BlackBerry port. It reflects changes in skia portion of webkit as well as skia itself.
Comment on attachment 133496 [details] accel comp updates Looks good, but needs ChangeLog.
Created attachment 133817 [details] Now with changelog
Comment on attachment 133817 [details] Now with changelog Looks good.
Comment on attachment 133817 [details] Now with changelog Rejecting attachment 133817 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ead.cpp patching file Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp patching file Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h rm 'Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h' patching file Source/WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12132846
Comment on attachment 133817 [details] Now with changelog Retry.
Comment on attachment 133817 [details] Now with changelog Rejecting attachment 133817 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ead.cpp patching file Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp patching file Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h rm 'Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h' patching file Source/WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12134883
Created attachment 133838 [details] Fixed patch
Attachment 133838 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h:32: #ifndef header guard has wrong style, please use: ImageBufferDataSkia_h [build/header_guard] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 133839 [details] Fixed style
Comment on attachment 133839 [details] Fixed style Looks good.
Comment on attachment 133839 [details] Fixed style Clearing flags on attachment: 133839 Committed r112124: <http://trac.webkit.org/changeset/112124>
All reviewed patches have been landed. Closing bug.