Bug 82058 - [BlackBerry] Accelerated compositing updates
: [BlackBerry] Accelerated compositing updates
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-23 09:05 PDT by Filip Spacek
Modified: 2012-03-26 10:43 PDT (History)
2 users (show)

See Also:


Attachments
accel comp updates (25.19 KB, patch)
2012-03-23 09:05 PDT, Filip Spacek
rwlbuis: review-
Details | Formatted Diff | Diff
Now with changelog (28.79 KB, patch)
2012-03-26 08:23 PDT, Filip Spacek
rwlbuis: review+
webkit.review.bot: commit‑queue-
Details | Formatted Diff | Diff
Fixed patch (28.75 KB, patch)
2012-03-26 09:49 PDT, Filip Spacek
no flags Details | Formatted Diff | Diff
Fixed style (28.77 KB, patch)
2012-03-26 09:59 PDT, Filip Spacek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Spacek 2012-03-23 09:05:51 PDT
Created attachment 133496 [details]
accel comp updates

Attached patch includes updates to the accelerated compositing code for BlackBerry port. It reflects changes in skia portion of webkit as well as skia itself.
Comment 1 Rob Buis 2012-03-26 07:51:44 PDT
Comment on attachment 133496 [details]
accel comp updates

Looks good, but needs ChangeLog.
Comment 2 Filip Spacek 2012-03-26 08:23:26 PDT
Created attachment 133817 [details]
Now with changelog
Comment 3 Rob Buis 2012-03-26 08:26:54 PDT
Comment on attachment 133817 [details]
Now with changelog

Looks good.
Comment 4 WebKit Review Bot 2012-03-26 08:53:34 PDT
Comment on attachment 133817 [details]
Now with changelog

Rejecting attachment 133817 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ead.cpp
patching file Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp
patching file Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h
rm 'Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h'
patching file Source/WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12132846
Comment 5 Rob Buis 2012-03-26 09:06:44 PDT
Comment on attachment 133817 [details]
Now with changelog

Retry.
Comment 6 WebKit Review Bot 2012-03-26 09:08:51 PDT
Comment on attachment 133817 [details]
Now with changelog

Rejecting attachment 133817 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ead.cpp
patching file Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp
patching file Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h
rm 'Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h'
patching file Source/WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12134883
Comment 7 Filip Spacek 2012-03-26 09:49:34 PDT
Created attachment 133838 [details]
Fixed patch
Comment 8 WebKit Review Bot 2012-03-26 09:56:12 PDT
Attachment 133838 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h:32:  #ifndef header guard has wrong style, please use: ImageBufferDataSkia_h  [build/header_guard] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Filip Spacek 2012-03-26 09:59:37 PDT
Created attachment 133839 [details]
Fixed style
Comment 10 Rob Buis 2012-03-26 10:28:40 PDT
Comment on attachment 133839 [details]
Fixed style

Looks good.
Comment 11 WebKit Review Bot 2012-03-26 10:43:20 PDT
Comment on attachment 133839 [details]
Fixed style

Clearing flags on attachment: 133839

Committed r112124: <http://trac.webkit.org/changeset/112124>
Comment 12 WebKit Review Bot 2012-03-26 10:43:25 PDT
All reviewed patches have been landed.  Closing bug.