Bug 82054 - [chromium] Remove unused variables from unittest.
Summary: [chromium] Remove unused variables from unittest.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Backer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-23 07:18 PDT by Jonathan Backer
Modified: 2012-03-23 07:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.91 KB, patch)
2012-03-23 07:18 PDT, Jonathan Backer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Backer 2012-03-23 07:18:14 PDT
[chromium] Remove unused variables from unittest.
Comment 1 Jonathan Backer 2012-03-23 07:18:52 PDT
Created attachment 133479 [details]
Patch
Comment 2 Jonathan Backer 2012-03-23 07:22:18 PDT
Newer GCC is warning about the unused variable.

CrOS builds with warnings as errors. So this is breaking building chrome for CrOS.
Comment 3 Dana Jansens 2012-03-23 07:23:25 PDT
Comment on attachment 133479 [details]
Patch

+1
Comment 4 Jonathan Backer 2012-03-23 07:25:46 PDT
jamesr@ or enne@, can I get an R+?
Comment 5 Adrienne Walker 2012-03-23 07:47:46 PDT
Comment on attachment 133479 [details]
Patch

We really need an ews bot that builds with this warning.  :(
Comment 6 WebKit Review Bot 2012-03-23 07:54:18 PDT
Comment on attachment 133479 [details]
Patch

Clearing flags on attachment: 133479

Committed r111862: <http://trac.webkit.org/changeset/111862>
Comment 7 WebKit Review Bot 2012-03-23 07:54:23 PDT
All reviewed patches have been landed.  Closing bug.