Bug 82011 - [chromium] Separate concepts of scissor rect and partial swap rect
Summary: [chromium] Separate concepts of scissor rect and partial swap rect
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shawn Singh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 21:24 PDT by Shawn Singh
Modified: 2013-04-04 12:59 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2012-03-22 21:24:14 PDT 
Currently the CCDamageTracker computes a damageRect that is a murky combination of scissorRect and partialSwapRect.  We should separate these two concepts, because they will not necessarily be the same rect:

1. scissorRect would be used to scissor the amount of stuff drawn to the back buffer.
2. partialSwapRect (or more generally, a collection of scissor rects that need to be swapped) would be used to swap regions of the backbuffer onto the front buffer.

When we really do make this distinction, it is probably not appropriate to keep both rects in the damage tracker.  Instead, we should create a CCPartialSwapAggregator, which retains a list of all the scissor rects that were used for drawing each frame, and uses that knowledge when the compositor asks to postSubBuffer.  It will also be far easier to test as a separate class.
Comment 1 Shawn Singh 2013-04-04 12:59:08 PDT 
This bug is obsolete.