Bug 82003 - [chromium] Disable failing unit test - CCLayerTreeHostImplTest.visibilityChangeResetsDamage
Summary: [chromium] Disable failing unit test - CCLayerTreeHostImplTest.visibilityChan...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michal Mocny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 19:19 PDT by Michal Mocny
Modified: 2012-03-22 19:50 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2012-03-22 19:19 PDT, Michal Mocny
no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2012-03-22 19:23 PDT, Michal Mocny
no flags Details | Formatted Diff | Diff
Patch (3.68 KB, patch)
2012-03-22 19:34 PDT, Michal Mocny
enne: review+
enne: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Mocny 2012-03-22 19:19:21 PDT
[chromium] Fix failing unit test - CCLayerTreeHostImplTest.visibilityChangeResetsDamage
Comment 1 Michal Mocny 2012-03-22 19:19:58 PDT
Created attachment 133412 [details]
Patch
Comment 2 Michal Mocny 2012-03-22 19:21:19 PDT
Comment on attachment 133412 [details]
Patch

This test is no longer expected to pass as written.  Visibility change does not trigger backbuffer drop and should reset damage.
Comment 3 Michal Mocny 2012-03-22 19:23:48 PDT
Created attachment 133413 [details]
Patch
Comment 4 Adrienne Walker 2012-03-22 19:30:15 PDT
Comment on attachment 133413 [details]
Patch

Is this test even worth having anymore now that visibility doesn't affect damage? Can we just delete the test?
Comment 5 Michal Mocny 2012-03-22 19:34:17 PDT
Created attachment 133415 [details]
Patch
Comment 6 Adrienne Walker 2012-03-22 19:43:01 PDT
Comment on attachment 133415 [details]
Patch

I'll land this by hand to fix the bots.  Thanks.  :)
Comment 7 Michal Mocny 2012-03-22 19:43:42 PDT
No no, thank you!
Comment 8 Adrienne Walker 2012-03-22 19:50:04 PDT
Committed r111815: <http://trac.webkit.org/changeset/111815>