Bug 81999 – Tools/Scripts/build-jsc doesn't work after WTF move

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Michael Saboff]

build-jsc doesn't appear to build WTF after the WTF move and fails with linker errors.

If WTF is built with build-webkit, then build-jsc appears to work.

[Eric Seidel (no email)]

It's slightly confusing becasue some of the ports build each directory independently, and some don't.  It looks liek Qt is already setup to build WTF before buidling JSC in this script.  I recommend we just hack AppleMac/AppleWin to do similar to Qt for now.

[Filip Pizlo]

I believe I have a fix for this.

[Filip Pizlo]

Created attachment 133400 [details]
the patch

[Eric Seidel (no email)]

Comment on attachment 133400 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review

This looks reasonable.

> Tools/Scripts/build-jsc:92
> +    chdir "../..";

chdrWebKit?

[Filip Pizlo]

(In reply to comment #4)
> (From update of attachment 133400 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review
> 
> This looks reasonable.
> 
> > Tools/Scripts/build-jsc:92
> > +    chdir "../..";
> 
> chdrWebKit?

Aha!  Didn't know about that, and it indeed works.  Will land with this change.

[Andy Estes]

Comment on attachment 133400 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review

> Source/JavaScriptCore/bytecode/SamplingTool.h:127
> -        static void dump();
> +        JS_EXPORT_PRIVATE static void dump();

Did you mean to include this? It doesn't look relevant.

[Filip Pizlo]

(In reply to comment #6)
> (From update of attachment 133400 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review
> 
> > Source/JavaScriptCore/bytecode/SamplingTool.h:127
> > -        static void dump();
> > +        JS_EXPORT_PRIVATE static void dump();
> 
> Did you mean to include this? It doesn't look relevant.

Good catch, and no, it is not relevant.  Will revert.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/111797