RESOLVED FIXED81983
Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page 
https://bugs.webkit.org/show_bug.cgi?id=81983
Summary Move garden-o-matic progress feedback from non-modal dialogs to a status cons...
Ojan Vafai
Reported 2012-03-22 15:57:48 PDT
Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
Attachments
Patch (14.00 KB, patch)
2012-03-22 16:02 PDT, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-03-22 16:02:05 PDT
Created attachment 133376 [details] Patch
Adam Barth
Comment 2 2012-03-22 17:05:55 PDT
Comment on attachment 133376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133376&action=review I assume this look pretty. :) > Tools/ChangeLog:10 > + The dialogs get in the way if you are doing multiple rebaselines. Also, > + a number of people didn't realize that you could do multiple rebaselines > + in parallel. A non-modal dialog is just confusing. I didn't realize you could do multiple rebaselines in parallel! > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:118 > + // FIXME: Why don't we use Object.values(dictionary)? Because I'm dumb and I didn't know that existed.
Ojan Vafai
Comment 3 2012-03-22 17:35:39 PDT
(In reply to comment #2) > (From update of attachment 133376 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133376&action=review > > I assume this look pretty. :) Not gonna win any beauty contests, but I think it's good enough. I'm happy to tweak it if you look at it and are disgusted. :) > > Tools/ChangeLog:10 > > + The dialogs get in the way if you are doing multiple rebaselines. Also, > > + a number of people didn't realize that you could do multiple rebaselines > > + in parallel. A non-modal dialog is just confusing. > > I didn't realize you could do multiple rebaselines in parallel! Lol. It works surprisingly well (albeit slowly). > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:118 > > + // FIXME: Why don't we use Object.values(dictionary)? > > Because I'm dumb and I didn't know that existed. Lol. I'll fix this in a followup patch.
Ojan Vafai
Comment 4 2012-03-22 17:36:33 PDT
Committed r111793: <http://trac.webkit.org/changeset/111793>
Note You need to log in before you can comment on or make changes to this bug.