Bug 81982 - Password protect "Stop build" button
Summary: Password protect "Stop build" button
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 15:56 PDT by Ryosuke Niwa
Modified: 2012-05-03 04:00 PDT (History)
5 users (show)

See Also:

Attachments
Temporarily remove stop buttons (1.29 KB, patch)
2012-03-23 03:23 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2012-04-27 07:14 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-22 15:56:28 PDT 
It seems like the ability to stop a build is more harmful than the ability to force a build since builds are triggered automatically by commits quite often whereas canceling a build results in permanent data loss.

We should password-protect "stop build" button instead.
Comment 1 Ryosuke Niwa 2012-03-23 03:20:17 PDT 
Someone cancelled interrupted all builds again :( This is getting really disruptive. Can we just turn off
    stopBuild=True,
    stopAllBuilds=True,
    cancelPendingBuild=True,
?
Comment 2 Ryosuke Niwa 2012-03-23 03:23:46 PDT 
Created attachment 133451 [details]
Temporarily remove stop buttons
Comment 3 Csaba Osztrogonác 2012-03-23 04:19:28 PDT 
Comment on attachment 133451 [details]
Temporarily remove stop buttons

I think it is a too drastical change. I prefer 'auth' instead of False.
Comment 4 Ryosuke Niwa 2012-03-23 04:28:06 PDT 
(In reply to comment #3)
> (From update of attachment 133451 [details])
> I think it is a too drastical change. I prefer 'auth' instead of False.

Okay. Please feel free to post a patch since I'm not about to write a patch at 4:30am in the morning :)
Comment 5 Csaba Osztrogonác 2012-04-27 07:14:41 PDT 
Created attachment 139197 [details]
Patch
Comment 6 Csaba Osztrogonác 2012-04-27 07:18:49 PDT 
Today a crazy SPAM bot killed all builds on build.webkit.org again.
Some of them during svn update which cause new svn checkout ...

It's time to ban non committers from pressing stop buttons.
Comment 7 Csaba Osztrogonác 2012-04-27 07:19:59 PDT 
The web-page 'stop build' button was pressed by '<unknown>': hhxwdqvcmjdtpvsdf, <a href="http://www.jxeilrvoxv.com">qmhnjcetgh</a> , [url=http://www.iwctwfsdnh.com]zyzkhmqvws[/url], http://www.fffkhacygs.com qmhnjcetgh

Additionally we should add an IP ban for this user too.
Comment 8 Csaba Osztrogonác 2012-05-02 01:57:27 PDT 
One more force stop by a SPAM-mer today:
The web-page 'stop build' button was pressed by '<unknown>': <no reason specified>

ping for review ...
Comment 9 Ryosuke Niwa 2012-05-02 07:28:44 PDT 
Comment on attachment 139197 [details]
Patch

So I realize that form elements that have stop buttons in them don't have input elements for the authentication. we'll need to add them there.
Comment 10 Csaba Osztrogonác 2012-05-02 07:31:30 PDT 
(In reply to comment #9)
> (From update of attachment 139197 [details])
> So I realize that form elements that have stop buttons in them don't have input elements for the authentication. we'll need to add them there.

It isn't problem. There is input elements for authentication if the authentication is enabled. Check our master - http://build.webkit.sed.hu ,
you can find stop button. We didn't need any hack. ;)
Comment 11 Ryosuke Niwa 2012-05-02 07:33:23 PDT 
Comment on attachment 139197 [details]
Patch

Okay.
Comment 12 Csaba Osztrogonác 2012-05-02 07:34:38 PDT 
Comment on attachment 139197 [details]
Patch

CQ-, I'm going to land it when most of the bots are IDLE.
Comment 13 Csaba Osztrogonác 2012-05-03 04:00:14 PDT 
Comment on attachment 139197 [details]
Patch

Clearing flags on attachment: 139197

Committed r115957: <http://trac.webkit.org/changeset/115957>
Comment 14 Csaba Osztrogonác 2012-05-03 04:00:22 PDT 
All reviewed patches have been landed.  Closing bug.