Bug 8198 - Hitting an assert on undo paste
Summary: Hitting an assert on undo paste
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Justin Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-05 10:55 PDT by Justin Garcia
Modified: 2006-04-05 14:47 PDT (History)
0 users

See Also:


Attachments
patch, changelog and layout tests (13.06 KB, patch)
2006-04-05 12:58 PDT, Justin Garcia
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2006-04-05 10:55:23 PDT
A combination of undoable and non-undoable removes are done from the ReplacementFragment.
Comment 1 Justin Garcia 2006-04-05 11:01:25 PDT
#0	0x02055ef4 in WebCore::RemoveNodeCommand::doUnapply at RemoveNodeCommand.cpp:57
#1	0x02044408 in WebCore::EditCommand::unapply at EditCommand.cpp:252
#2	0x0203a190 in WebCore::CompositeEditCommand::doUnapply at CompositeEditCommand.cpp:78
#3	0x02044408 in WebCore::EditCommand::unapply at EditCommand.cpp:252
#4	0x01ee9bb4 in -[WebCoreFrameBridge undoEditing:] at WebCoreFrameBridge.mm:1584
Comment 2 Justin Garcia 2006-04-05 12:58:19 PDT
Created attachment 7531 [details]
patch, changelog and layout tests
Comment 3 Darin Adler 2006-04-05 14:09:37 PDT
Comment on attachment 7531 [details]
patch, changelog and layout tests

Typo in a couple places: "non-undable".

Looks good, r=me.

I'd like to see a clearer distinction between undoable and normal operations. Maybe we need to rename the undoable functions.