Bug 81979 - [Chromium] IndexedDB: Need test of Typed Arrays
Summary: [Chromium] IndexedDB: Need test of Typed Arrays
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 15:40 PDT by Joshua Bell
Modified: 2012-07-10 14:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.25 KB, patch)
2012-07-10 11:48 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-03-22 15:40:17 PDT
Typed Arrays are supported, but we don't have any tests that verify this to watch for regressions. Test should cover:

* put/get of typed arrays (Uint8Array and friends)
* use of arrays in stores with key paths (that involve extra SSV round-trips to Chromium's webkit utility process for key extraction)
Comment 1 Joshua Bell 2012-07-10 11:48:58 PDT
Created attachment 151497 [details]
Patch
Comment 2 Joshua Bell 2012-07-10 11:49:32 PDT
tony@ - r?
Comment 3 Alec Flett 2012-07-10 11:52:24 PDT
LGTM
(never knew about the JS test systems is() function ... good to know)
Comment 4 Joshua Bell 2012-07-10 11:55:51 PDT
(In reply to comment #3)
> LGTM
> (never knew about the JS test systems is() function ... good to know)

It's actually local to this test - I needed something that handled -0 and NaN properly. It should probably get pushed into the libraries at some point.
Comment 5 WebKit Review Bot 2012-07-10 14:21:51 PDT
Comment on attachment 151497 [details]
Patch

Clearing flags on attachment: 151497

Committed r122262: <http://trac.webkit.org/changeset/122262>
Comment 6 WebKit Review Bot 2012-07-10 14:21:55 PDT
All reviewed patches have been landed.  Closing bug.