Bug 81975 - DFG NodeFlags has some duplicate code and naming issues
Summary: DFG NodeFlags has some duplicate code and naming issues
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-03-22 15:05 PDT by Filip Pizlo
Modified: 2012-03-22 16:25 PDT (History)
0 users

See Also:

the patch (17.90 KB, patch)
2012-03-22 15:35 PDT, Filip Pizlo
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-03-22 15:05:42 PDT
The notion that some flags are "ArithNodeFlags" is mostly antiquated.

The renaming from NodeUse to Edge messed up some node flags names (NodeUsedAsNum become EdgedAsNum ... ooops).

It appears that we have a method called setArithNodeFlag() which is never called.

It appears that we have both mergeArithNodeFlags and mergeFlags.  The former has some assertions, which may be useful - but it's sad that we have two methods that really do the same thing.
Comment 1 Filip Pizlo 2012-03-22 15:35:22 PDT
Created attachment 133368 [details]
the patch
Comment 2 Filip Pizlo 2012-03-22 16:25:46 PDT
Landed in http://trac.webkit.org/changeset/111781