Bug 81966 - [BlackBerry] DeviceDPI Scaling is broken on mobile.
Summary: [BlackBerry] DeviceDPI Scaling is broken on mobile.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 14:28 PDT by Mike Lattanzio
Modified: 2012-03-22 15:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.35 KB, patch)
2012-03-22 14:42 PDT, Mike Lattanzio
no flags Details | Formatted Diff | Diff
Patch (2.36 KB, patch)
2012-03-22 14:48 PDT, Mike Lattanzio
no flags Details | Formatted Diff | Diff
Patch (2.31 KB, patch)
2012-03-22 15:06 PDT, Mike Lattanzio
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lattanzio 2012-03-22 14:28:28 PDT
We are not correctly handling viewport meta arguments for mobile devices.
Comment 1 Mike Lattanzio 2012-03-22 14:42:48 PDT
Created attachment 133349 [details]
Patch
Comment 2 Rob Buis 2012-03-22 14:46:21 PDT
Comment on attachment 133349 [details]
Patch

Reviewed by seems wrong, no indentation, this will ikely not automate.
Comment 3 Mike Lattanzio 2012-03-22 14:48:27 PDT
Created attachment 133352 [details]
Patch
Comment 4 Rob Buis 2012-03-22 14:49:21 PDT
Comment on attachment 133352 [details]
Patch

Looks good.
Comment 5 WebKit Review Bot 2012-03-22 14:53:19 PDT
Comment on attachment 133352 [details]
Patch

Rejecting attachment 133352 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Konrad Piascik found in /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12113262
Comment 6 Mike Lattanzio 2012-03-22 15:06:02 PDT
Created attachment 133356 [details]
Patch
Comment 7 Rob Buis 2012-03-22 15:06:53 PDT
Comment on attachment 133356 [details]
Patch

Another try.
Comment 8 WebKit Review Bot 2012-03-22 15:33:10 PDT
Comment on attachment 133356 [details]
Patch

Clearing flags on attachment: 133356

Committed r111774: <http://trac.webkit.org/changeset/111774>
Comment 9 WebKit Review Bot 2012-03-22 15:33:15 PDT
All reviewed patches have been landed.  Closing bug.