Bug 81964 - Improve soft hyphen testing
Summary: Improve soft hyphen testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Tharp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 14:15 PDT by Dave Tharp
Modified: 2012-03-23 09:12 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.55 KB, patch)
2012-03-22 14:18 PDT, Dave Tharp
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Tharp 2012-03-22 14:15:48 PDT
As part of a webkit patch (bug 76932) to fix the QT 4.8.0 soft hyphen problem, I created a layout test to expose the failure.

The actual code patch was rejected (the team doesn't want a hack in webkit, they want a proper fix in QT), but the test itself adds value. This bug is for adding only the test.
Comment 1 Dave Tharp 2012-03-22 14:18:30 PDT
Created attachment 133342 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-22 15:51:06 PDT
Comment on attachment 133342 [details]
Patch

Rejecting attachment 133342 [details] from commit-queue.

dtharp@codeaurora.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 WebKit Review Bot 2012-03-22 18:04:21 PDT
Comment on attachment 133342 [details]
Patch

Clearing flags on attachment: 133342

Committed r111801: <http://trac.webkit.org/changeset/111801>
Comment 4 WebKit Review Bot 2012-03-22 18:04:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryosuke Niwa 2012-03-23 00:50:34 PDT
The test added by this patch is failing on Qt bots :(

http://build.webkit.org/results/Qt%20Linux%20Release/r111801%20(44828)/results.html
Comment 6 Ryosuke Niwa 2012-03-23 00:51:50 PDT
+ossy. He can decide what to do with fast/text/soft-hyphen-5.html here.
Comment 7 Dave Tharp 2012-03-23 09:08:24 PDT
(In reply to comment #5)
> The test added by this patch is failing on Qt bots :(
> 
> http://build.webkit.org/results/Qt%20Linux%20Release/r111801%20(44828)/results.html
What version of QT are the build bots using?  It is possible that soft-hyphen is not yet supported in QTextBoundaryFinder in the version used by the build bots. It is likely this test is catching a real issue.  See bug 76932.
Comment 8 Csaba Osztrogonác 2012-03-23 09:12:34 PDT
It fails with Qt 4.8.0, so I skipped it - http://trac.webkit.org/changeset/111842/trunk/LayoutTests/platform/qt-4.8/Skipped