Bug 81961 - OLD_COMPILE_FLAGS was set incorrectly in WebKitHelpers.cmake
Summary: OLD_COMPILE_FLAGS was set incorrectly in WebKitHelpers.cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 14:06 PDT by Ming Xie
Modified: 2012-03-22 15:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2012-03-22 14:13 PDT, Ming Xie 		no flags Details | Formatted Diff | Diff
Patch (1.29 KB, patch)
2012-03-22 14:20 PDT, Ming Xie 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Xie 2012-03-22 14:06:22 PDT 
This is a regression from trunk@109292

    IF (${TARGET_TYPE} STREQUAL "STATIC_LIBRARY") # -fPIC is automatically added to shared libraries
        SET(OLD_COMPILE_FLAGS "-fPIC")
    ENDIF ()

All the previous OLD_COMPILE_FLAGS are gone in this condition.
Comment 1 Ming Xie 2012-03-22 14:13:19 PDT 
Created attachment 133340 [details]
Patch
Comment 2 Rob Buis 2012-03-22 14:17:32 PDT 
Comment on attachment 133340 [details]
Patch

Looks good, not proper reference.
Comment 3 Ming Xie 2012-03-22 14:20:54 PDT 
Created attachment 133344 [details]
Patch
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-03-22 14:21:12 PDT 
Sorry about that!
Comment 5 Rob Buis 2012-03-22 14:23:25 PDT 
Comment on attachment 133344 [details]
Patch

Looks good.
Comment 6 WebKit Review Bot 2012-03-22 15:01:53 PDT 
Comment on attachment 133344 [details]
Patch

Clearing flags on attachment: 133344

Committed r111769: <http://trac.webkit.org/changeset/111769>
Comment 7 WebKit Review Bot 2012-03-22 15:01:57 PDT 
All reviewed patches have been landed.  Closing bug.