RESOLVED FIXED81961
OLD_COMPILE_FLAGS was set incorrectly in WebKitHelpers.cmake 
https://bugs.webkit.org/show_bug.cgi?id=81961
Summary OLD_COMPILE_FLAGS was set incorrectly in WebKitHelpers.cmake
Ming Xie
Reported 2012-03-22 14:06:22 PDT
This is a regression from trunk@109292 IF (${TARGET_TYPE} STREQUAL "STATIC_LIBRARY") # -fPIC is automatically added to shared libraries SET(OLD_COMPILE_FLAGS "-fPIC") ENDIF () All the previous OLD_COMPILE_FLAGS are gone in this condition.
Attachments
Patch (1.29 KB, patch)
2012-03-22 14:13 PDT, Ming Xie 		no flags
DetailsFormatted DiffDiff
Patch (1.29 KB, patch)
2012-03-22 14:20 PDT, Ming Xie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ming Xie
Comment 1 2012-03-22 14:13:19 PDT
Created attachment 133340 [details] Patch
Rob Buis
Comment 2 2012-03-22 14:17:32 PDT
Comment on attachment 133340 [details] Patch Looks good, not proper reference.
Ming Xie
Comment 3 2012-03-22 14:20:54 PDT
Created attachment 133344 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-03-22 14:21:12 PDT
Sorry about that!
Rob Buis
Comment 5 2012-03-22 14:23:25 PDT
Comment on attachment 133344 [details] Patch Looks good.
WebKit Review Bot
Comment 6 2012-03-22 15:01:53 PDT
Comment on attachment 133344 [details] Patch Clearing flags on attachment: 133344 Committed r111769: <http://trac.webkit.org/changeset/111769>
WebKit Review Bot
Comment 7 2012-03-22 15:01:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.