Bug 81960 - Increase code sharing between StylePropertySet and CSSPropertyLonghand.
Summary: Increase code sharing between StylePropertySet and CSSPropertyLonghand.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 13:37 PDT by Alexis Menard (darktears)
Modified: 2012-03-26 05:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (24.94 KB, patch)
2012-03-22 13:42 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch (23.55 KB, patch)
2012-03-22 14:20 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch for landing (24.71 KB, patch)
2012-03-26 04:28 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch for landing (25.39 KB, patch)
2012-03-26 04:33 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-03-22 13:37:57 PDT
Increase code sharing between StylePropertySet and CSSPropertyLonghand.
Comment 1 Alexis Menard (darktears) 2012-03-22 13:42:33 PDT
Created attachment 133338 [details]
Patch
Comment 2 Alexis Menard (darktears) 2012-03-22 14:20:31 PDT
Created attachment 133343 [details]
Patch
Comment 3 Antti Koivisto 2012-03-22 14:59:46 PDT
nice, r=me
Comment 4 WebKit Review Bot 2012-03-22 15:28:24 PDT
Comment on attachment 133343 [details]
Patch

Attachment 133343 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12123184

New failing tests:
fast/dom/background-shorthand-csstext.html
fast/backgrounds/repeat/parsing-background-repeat.html
Comment 5 Alexis Menard (darktears) 2012-03-22 19:07:30 PDT
(In reply to comment #4)
> (From update of attachment 133343 [details])
> Attachment 133343 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12123184
> 
> New failing tests:
> fast/dom/background-shorthand-csstext.html
> fast/backgrounds/repeat/parsing-background-repeat.html

Will look at the failures on monday.
Comment 6 Alexis Menard (darktears) 2012-03-26 04:28:00 PDT
Created attachment 133774 [details]
Patch for landing
Comment 7 Alexis Menard (darktears) 2012-03-26 04:33:28 PDT
Created attachment 133775 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-03-26 05:12:04 PDT
Comment on attachment 133775 [details]
Patch for landing

Clearing flags on attachment: 133775

Committed r112078: <http://trac.webkit.org/changeset/112078>
Comment 9 WebKit Review Bot 2012-03-26 05:12:14 PDT
All reviewed patches have been landed.  Closing bug.