81958 – REGRESSION (r105453): Crash when handling touch events

Bug 81958 - REGRESSION (r105453): Crash when handling touch events

Summary: REGRESSION (r105453): Crash when handling touch events

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebCore Misc. (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Critical
Assignee:	Nobody

URL:
Keywords:	Regression

Depends on:
Blocks:

Reported:	2012-03-22 13:29 PDT by Yong Li
Modified:	2012-04-17 08:47 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
The patch (2.96 KB, patch) 2012-03-23 11:44 PDT, Yong Li	no flags	Details \| Formatted Diff \| Diff
changelog updated (3.12 KB, patch) 2012-04-02 11:27 PDT, Yong Li	tonikitoo: review+	Details \| Formatted Diff \| Diff
try again (3.16 KB, patch) 2012-04-17 07:38 PDT, Yong Li	yong.li.webkit: commit-queue-	Details \| Formatted Diff \| Diff
Again (3.16 KB, patch) 2012-04-17 07:44 PDT, Yong Li	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yong Li 2012-03-22 13:29:54 PDT

In the case touched document is deleted by touchstart and touchmove, WebKit will crash when processing the subsequent touch events on the same node.

This is a regression of r105453, Bug 75506

Comment 1 Yong Li 2012-03-23 07:51:05 PDT

I've got a fix and a manual test, working on a auto layout test

Comment 2 Yong Li 2012-03-23 11:44:15 PDT

Created attachment 133524 [details]
The patch

I'm adding a manual test. To cover this with a layout test, we have to make DRT support sending a few touch points with different states (pressed, moved, released) in one shot. I'll open another bug for that

Comment 3 Yong Li 2012-04-02 11:27:48 PDT

Created attachment 135139 [details]
changelog updated

Comment 4 Min Qin 2012-04-02 11:38:43 PDT

Thanks for fixing this.

Looks good to me

Comment 5 Antonio Gomes 2012-04-02 12:57:34 PDT

I will work on the blocking bug 82075 to make it possible to layout test it.

(In reply to comment #2)
> Created an attachment (id=133524) [details]
> The patch
> 
> I'm adding a manual test. To cover this with a layout test, we have to make DRT support sending a few touch points with different states (pressed, moved, released) in one shot. I'll open another bug for that

Comment 6 WebKit Review Bot 2012-04-02 13:16:06 PDT

Comment on attachment 135139 [details]
changelog updated

Rejecting attachment 135139 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12311665

Comment 7 Allan Sandfeld Jensen 2012-04-17 07:10:15 PDT

(In reply to comment #6)
> (From update of attachment 135139 [details])
> Rejecting attachment 135139 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> 
> ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> 
> Full output: http://queues.webkit.org/results/12311665

I think the line "Review By" was accidentally removed from the ChangeLog of Manual tests, this failed to merge in the viewer which failed the commit bot. It should be a simple update.

Comment 8 Yong Li 2012-04-17 07:38:17 PDT

Created attachment 137534 [details]
try again

Comment 9 Yong Li 2012-04-17 07:44:50 PDT

Created attachment 137536 [details]
Again

Comment 10 WebKit Review Bot 2012-04-17 08:20:21 PDT

Comment on attachment 137536 [details]
Again

Clearing flags on attachment: 137536

Committed r114379: <http://trac.webkit.org/changeset/114379>