Bug 81958 – REGRESSION (r105453): Crash when handling touch events

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Yong Li]

In the case touched document is deleted by touchstart and touchmove, WebKit will crash when processing the subsequent touch events on the same node.

This is a regression of r105453, Bug 75506

[Yong Li]

I've got a fix and a manual test, working on a auto layout test

[Yong Li]

Created attachment 133524 [details]
The patch

I'm adding a manual test. To cover this with a layout test, we have to make DRT support sending a few touch points with different states (pressed, moved, released) in one shot. I'll open another bug for that

[Yong Li]

Created attachment 135139 [details]
changelog updated

[Min Qin]

Thanks for fixing this.

Looks good to me

[Antonio Gomes]

I will work on the blocking bug 82075 to make it possible to layout test it.

(In reply to comment #2)
> Created an attachment (id=133524) [details]
> The patch
> 
> I'm adding a manual test. To cover this with a layout test, we have to make DRT support sending a few touch points with different states (pressed, moved, released) in one shot. I'll open another bug for that

[WebKit Review Bot]

Comment on attachment 135139 [details]
changelog updated

Rejecting attachment 135139 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12311665

[Allan Sandfeld Jensen]

(In reply to comment #6)
> (From update of attachment 135139 [details])
> Rejecting attachment 135139 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> 
> ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> 
> Full output: http://queues.webkit.org/results/12311665

I think the line "Review By" was accidentally removed from the ChangeLog of Manual tests, this failed to merge in the viewer which failed the commit bot. It should be a simple update.

[Yong Li]

Created attachment 137534 [details]
try again

[Yong Li]

Created attachment 137536 [details]
Again

[WebKit Review Bot]

Comment on attachment 137536 [details]
Again

Clearing flags on attachment: 137536

Committed r114379: <http://trac.webkit.org/changeset/114379>