Bug 81951 - new-run-webkit-tests blames the wrong test for crashing
Summary: new-run-webkit-tests blames the wrong test for crashing
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
Depends on:
Reported: 2012-03-22 12:56 PDT by Geoffrey Garen
Modified: 2012-03-22 14:24 PDT (History)
6 users (show)

See Also:

Patch (6.12 KB, patch)
2012-03-22 13:58 PDT, Dirk Pranke
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-03-22 12:56:13 PDT
See http://build.webkit.org/results/Lion%20Intel%20Release%20(WebKit2%20Tests)/r111739%20(5620)/results.html. It lists these tests as crashing in workers code:


Only one of these tests actually runs a worker.
Comment 1 Dirk Pranke 2012-03-22 13:10:47 PDT
Okay, it looks like we're not picking up the pid of the WebProcess properly (which was added in r111619), so they're all probably picking up the most recent crash logs that they find at the time.

Investigating further to see why we're not getting the pid ...
Comment 2 Dirk Pranke 2012-03-22 13:58:28 PDT
Created attachment 133339 [details]
Comment 3 Dirk Pranke 2012-03-22 14:00:07 PDT
some day this code will all be right ... that'll be a nice day.
Comment 4 Dirk Pranke 2012-03-22 14:04:36 PDT
thanks for the review!
Comment 5 Dirk Pranke 2012-03-22 14:24:36 PDT
Committed r111765: <http://trac.webkit.org/changeset/111765>