WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81944
[BlackBerry] Add pattern matching for hexadecimal type input fields
https://bugs.webkit.org/show_bug.cgi?id=81944
Summary
[BlackBerry] Add pattern matching for hexadecimal type input fields
Mike Fenton
Reported
2012-03-22 11:58:47 PDT
If the pattern attribute of a text input field indicates it only accept hexadecimal input it should be treated as a hexadecimal type.
Attachments
Patch
(5.67 KB, patch)
2012-03-22 12:02 PDT
,
Mike Fenton
rwlbuis
: review+
rwlbuis
: commit-queue-
Details
Formatted Diff
Diff
Updated Patch
(5.66 KB, patch)
2012-03-22 12:18 PDT
,
Mike Fenton
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mike Fenton
Comment 1
2012-03-22 12:02:03 PDT
Created
attachment 133311
[details]
Patch
Rob Buis
Comment 2
2012-03-22 12:13:34 PDT
Comment on
attachment 133311
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=133311&action=review
Looks good, with one cleanup possibility.
> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:388 > +bool elementPatternIndicatesHexadecimal(const WebCore::HTMLInputElement* inputElement)
No need for WebCore:: prefix.
Mike Fenton
Comment 3
2012-03-22 12:18:58 PDT
Created
attachment 133321
[details]
Updated Patch
WebKit Review Bot
Comment 4
2012-03-22 15:12:40 PDT
Comment on
attachment 133321
[details]
Updated Patch Clearing flags on attachment: 133321 Committed
r111772
: <
http://trac.webkit.org/changeset/111772
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug