Bug 81944 - [BlackBerry] Add pattern matching for hexadecimal type input fields
Summary: [BlackBerry] Add pattern matching for hexadecimal type input fields
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
Depends on:
Reported: 2012-03-22 11:58 PDT by Mike Fenton
Modified: 2012-04-13 13:40 PDT (History)
3 users (show)

See Also:

Patch (5.67 KB, patch)
2012-03-22 12:02 PDT, Mike Fenton
rwlbuis: review+
rwlbuis: commit-queue-
Details | Formatted Diff | Diff
Updated Patch (5.66 KB, patch)
2012-03-22 12:18 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-03-22 11:58:47 PDT
If the pattern attribute of a text input field indicates it only accept hexadecimal input it should be treated as a hexadecimal type.
Comment 1 Mike Fenton 2012-03-22 12:02:03 PDT
Created attachment 133311 [details]
Comment 2 Rob Buis 2012-03-22 12:13:34 PDT
Comment on attachment 133311 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=133311&action=review

Looks good, with one cleanup possibility.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:388
> +bool elementPatternIndicatesHexadecimal(const WebCore::HTMLInputElement* inputElement)

No need for WebCore:: prefix.
Comment 3 Mike Fenton 2012-03-22 12:18:58 PDT
Created attachment 133321 [details]
Updated Patch
Comment 4 WebKit Review Bot 2012-03-22 15:12:40 PDT
Comment on attachment 133321 [details]
Updated Patch

Clearing flags on attachment: 133321

Committed r111772: <http://trac.webkit.org/changeset/111772>