Bug 81933 - [Qt][WK2] default families are not set in QWebPreferences
Summary: [Qt][WK2] default families are not set in QWebPreferences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pierre Rossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 10:13 PDT by Pierre Rossi
Modified: 2012-03-26 11:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.20 KB, patch)
2012-03-22 10:20 PDT, Pierre Rossi 		kenneth: review+
Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2012-03-26 11:11 PDT, Rafael Brandao 		vestbo: review+
vestbo: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Rossi 2012-03-22 10:13:58 PDT 
[Qt][WK2] default families are not set in QWebPreferences
Comment 1 Pierre Rossi 2012-03-22 10:20:25 PDT 
Created attachment 133288 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-03-23 04:27:03 PDT 
Comment on attachment 133288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133288&action=review

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:101
> +void QWebPreferencesPrivate::initFontDefaults()

WebKit usually usees initialize and not init

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:124
> +    setFontFamily(FixedFont, defaultFont.defaultFamily());
> +
> +}

unneeded newline!
Comment 3 Kenneth Rohde Christiansen 2012-03-23 04:27:30 PDT 
Comment on attachment 133288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133288&action=review

>> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:101
>> +void QWebPreferencesPrivate::initFontDefaults()
> 
> WebKit usually usees initialize and not init

Also doesn DefaultFonts make more sense than FontDefaults?
Comment 4 Pierre Rossi 2012-03-26 10:05:05 PDT 
Committed r112116: <http://trac.webkit.org/changeset/112116>
Comment 5 Rafael Brandao 2012-03-26 11:11:03 PDT 
Reopening to attach new patch.
Comment 6 Rafael Brandao 2012-03-26 11:11:08 PDT 
Created attachment 133849 [details]
Patch

This patch has broken qt bots. This is the build fix, please land this ASAP.
Comment 7 Tor Arne Vestbø 2012-03-26 11:39:33 PDT 
Landed in r112132