Bug 81929 - [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
Summary: [BlackBerry] DOMSupport isPositionInNode should have early returns for null n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 09:46 PDT by Mike Fenton
Modified: 2012-03-22 13:58 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2012-03-22 09:55 PDT, Mike Fenton 		no flags Details | Formatted Diff | Diff
Patch with style suggestion made. (2.18 KB, patch)
2012-03-22 11:47 PDT, Mike Fenton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-03-22 09:46:27 PDT 
isPositionInNode should have early returns when the node, or the Position Node is null.
Comment 1 Mike Fenton 2012-03-22 09:55:39 PDT 
Created attachment 133283 [details]
Patch
Comment 2 Rob Buis 2012-03-22 10:29:57 PDT 
Comment on attachment 133283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133283&action=review

Looks good.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:299
>      int offset = 0;

I would personally move this just before it is used, but no big deal.
Comment 3 WebKit Review Bot 2012-03-22 10:38:54 PDT 
Comment on attachment 133283 [details]
Patch

Clearing flags on attachment: 133283

Committed r111726: <http://trac.webkit.org/changeset/111726>
Comment 4 WebKit Review Bot 2012-03-22 10:38:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Mike Fenton 2012-03-22 11:46:34 PDT 
Re-open for style patch.
Comment 6 Mike Fenton 2012-03-22 11:47:02 PDT 
Created attachment 133308 [details]
Patch with style suggestion made.
Comment 7 Rob Buis 2012-03-22 11:48:10 PDT 
Comment on attachment 133308 [details]
Patch with style suggestion made.

Thanks!
Comment 8 WebKit Review Bot 2012-03-22 13:58:32 PDT 
Comment on attachment 133308 [details]
Patch with style suggestion made.

Clearing flags on attachment: 133308

Committed r111757: <http://trac.webkit.org/changeset/111757>
Comment 9 WebKit Review Bot 2012-03-22 13:58:36 PDT 
All reviewed patches have been landed.  Closing bug.