Bug 81914 - [EFL] LayoutTestController needs implementation of goBack
Summary: [EFL] LayoutTestController needs implementation of goBack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 08:22 PDT by Mikhail Pozdnyakov
Modified: 2012-05-06 22:48 PDT (History)
5 users (show)

See Also:

Attachments
LayoutTestController goBack feature implementation. (4.30 KB, patch)
2012-03-24 16:00 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Improved patch based on review (5.27 KB, patch)
2012-03-26 23:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Proposed patch (2.52 KB, patch)
2012-04-02 05:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Proposed patch (2.56 KB, patch)
2012-04-03 03:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-03-22 08:22:11 PDT 
LayoutTestController needs implementation of goBack in order to unskip loader/navigation-while-deferring-loads.html.
Comment 1 Mikhail Pozdnyakov 2012-03-24 16:00:43 PDT 
Created attachment 133658 [details]
LayoutTestController goBack feature implementation.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-03-24 17:34:45 PDT 
Comment on attachment 133658 [details]
LayoutTestController goBack feature implementation.

View in context: https://bugs.webkit.org/attachment.cgi?id=133658&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:609
> +    DumpRenderTreeSupportEfl::goBack(browser->mainView());

ewk_frame_navigate()?
Comment 3 Gyuyoung Kim 2012-03-24 19:16:18 PDT 
Comment on attachment 133658 [details]
LayoutTestController goBack feature implementation.

View in context: https://bugs.webkit.org/attachment.cgi?id=133658&action=review

> LayoutTests/ChangeLog:7
> +

It looks you need to add simple description for this patch

>> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:609
>> +    DumpRenderTreeSupportEfl::goBack(browser->mainView());
> 
> ewk_frame_navigate()?

There are also ewk_frame_back(), ewk_frame_back_possible(). It seems to me that we don't need to add an function to DumpRenderTreeSupportEfl because ewk already supports APIs for backward | forward.
Comment 4 Chris Dumez 2012-03-26 23:44:50 PDT 
Created attachment 133985 [details]
Improved patch based on review

The patch also bring implementation for setDefersLoading() so that the loader/navigation-while-deferring-loads.html test can be removed from skip-list.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-03-27 07:39:46 PDT 
Both changes look OK, but they seem unrelated to me. Can you explain your reasoning for not splitting these up into two patches?
Comment 6 Chris Dumez 2012-04-02 05:25:25 PDT 
Created attachment 135073 [details]
Proposed patch

Split with #82890
Comment 7 Gyuyoung Kim 2012-04-02 17:47:16 PDT 
Comment on attachment 135073 [details]
Proposed patch

Looks good to me.
Comment 8 Chris Dumez 2012-04-03 03:22:15 PDT 
Created attachment 135297 [details]
Proposed patch

Updated LayoutTests/ChangeLog based on philn-tp's feedback.
Comment 9 WebKit Review Bot 2012-04-03 05:11:24 PDT 
Comment on attachment 135297 [details]
Proposed patch

Clearing flags on attachment: 135297

Committed r113015: <http://trac.webkit.org/changeset/113015>
Comment 10 WebKit Review Bot 2012-04-03 05:11:29 PDT 
All reviewed patches have been landed.  Closing bug.