Bug 81913 - Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
Summary: Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 08:19 PDT by Björn Toschi
Modified: 2012-04-25 04:35 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2012-04-25 02:18 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2012-04-25 02:37 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (2.96 KB, patch)
2012-04-25 02:40 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Toschi 2012-03-22 08:19:58 PDT
System is Kubuntu 8.04 shipping gstreamer 0.10.18. 
Ancient, I know :P

Building Webkit shipped with Qt 4.8.0 fails due missing include of <gst/interfaces/streamvolume.h> from "Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp".
As far as I can see, the affected Webkit version is from November 2011.

The missing include file does not exist in versions prior to gstreamer 0.10.27 (as far as I checked its gstreamer repositories),
and the configuration (taking place in Source/WebCore/features.pri in Qt's version)
only checks for existence of gstreamer-0.10 (development) package using pkg-config, not for its version.

There is a simple one-line patch (disabling HTML5 Video in that case):

diff Source/WebCore/features.pri.shipped Source/WebCore/features.pri
171c171
<         !contains(QT_CONFIG, no-pkg-config):system(pkg-config --exists glib-2.0 gio-2.0 gstreamer-0.10): {
---
>         !contains(QT_CONFIG, no-pkg-config):system(pkg-config --exists glib-2.0 gio-2.0 \'gstreamer-0.10 >= 0.10.27\'): {


Note that the .pri file was moved to Tools/make/mkspecs/features.prf with c99274, but as far as I can see even recent versions should be affected by this issue.
Comment 1 Philippe Normand 2012-04-19 14:40:50 PDT
Would that be ok, Alexis?
Comment 2 Alexis Menard (darktears) 2012-04-19 14:43:11 PDT
WTF.pri needs to be patched. You mind uploading a patch? Thanks.
Comment 3 Philippe Normand 2012-04-25 02:18:44 PDT
Created attachment 138763 [details]
Patch
Comment 4 Tor Arne Vestbø 2012-04-25 02:27:42 PDT
Hmm, the logic in WTF.pri is a bit busted here. It shouldn't replicate features.prf, but do something like:

linux-*:contains(DEFINES, WTF_USE_GSTREAMER=1) {
    DEFINES += ENABLE_GLIB_SUPPORT=1
    PKGCONFIG += glib-2.0 gio-2.0
}

(See similar logic in WebCore.pri)

and the patch you posted should be made to features.prf. Sorry for the confusion :/
Comment 5 Philippe Normand 2012-04-25 02:37:19 PDT
Created attachment 138768 [details]
Patch
Comment 6 Philippe Normand 2012-04-25 02:40:08 PDT
Created attachment 138770 [details]
Patch
Comment 7 Tor Arne Vestbø 2012-04-25 02:51:45 PDT
Comment on attachment 138768 [details]
Patch

great! thanks!
Comment 8 WebKit Review Bot 2012-04-25 04:35:39 PDT
Comment on attachment 138770 [details]
Patch

Clearing flags on attachment: 138770

Committed r115184: <http://trac.webkit.org/changeset/115184>
Comment 9 WebKit Review Bot 2012-04-25 04:35:44 PDT
All reviewed patches have been landed.  Closing bug.