Bug 81910 - [Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject
Summary: [Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Færøy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 07:53 PDT by Alexander Færøy
Modified: 2012-03-22 10:23 PDT (History)
3 users (show)

See Also:


Attachments
Patch (13.36 KB, patch)
2012-03-22 07:58 PDT, Alexander Færøy
no flags Details | Formatted Diff | Diff
Patch (12.87 KB, patch)
2012-03-22 09:11 PDT, Alexander Færøy
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Færøy 2012-03-22 07:53:22 PDT
[Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject
Comment 1 Alexander Færøy 2012-03-22 07:58:18 PDT
Created attachment 133264 [details]
Patch
Comment 2 Alexander Færøy 2012-03-22 09:11:18 PDT
Created attachment 133274 [details]
Patch
Comment 3 Simon Hausmann 2012-03-22 09:50:12 PDT
Comment on attachment 133274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133274&action=review

> Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:213
> +        WKRetainPtr<WKStringRef> scheme = adoptWK(WKSecurityOriginCopyProtocol(securityOrigin));
> +        WKRetainPtr<WKStringRef> host = adoptWK(WKSecurityOriginCopyHost(securityOrigin));
> +
> +        m_securityOrigin.setScheme(WKStringCopyQString(scheme.get()));
> +        m_securityOrigin.setHost(WKStringCopyQString(host.get()));
> +        m_securityOrigin.setPort(static_cast<int>(WKSecurityOriginGetPort(securityOrigin)));

Would be nice to have a constructor for this in the future.
Comment 4 Alexander Færøy 2012-03-22 10:23:53 PDT
Committed r111721: <http://trac.webkit.org/changeset/111721>