Bug 81890 – Merge SVGImageBufferTools to SVGRenderingContext

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Zoltan Herczeg]

Copy the methods, no functionality change.

[Zoltan Herczeg]

Created attachment 133221 [details]
patch

[Nikolas Zimmermann]

Comment on attachment 133221 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133221&action=review

Looks great, r=me, in case cr-linux ews bot is also happy with it.

> Source/WebCore/ChangeLog:11
> +        no functionality change.
> +

You should note here, that this is the first step, towards making SVGImageBufferTools stageful, and this only moves the code.

[Zoltan Herczeg]

Thanks for the review. Landed as http://trac.webkit.org/changeset/111674

[Dirk Schulze]

I'm not opposed to the change, but what is the reason for moving it?

[Nikolas Zimmermann]

(In reply to comment #4)
> I'm not opposed to the change, but what is the reason for moving it?
Sorry for not including more context here, I discuss this since a while with Zoltan.
The goal is to change the current state-less design of SVGImageBufferTools/SVGRenderingSupport. As first step Zoltan extracted the prepareRenderSVGContent/finishREnderSVGContent from SVGRenderSupport into SVGRenderingContext, making it state-full (not a bunch of static functions, but a real class holding data). This simplifies the SVG subtree rendering code a lot.

SVGImageBufferTools suffers from the same problem. The intent is to merge it into SVGRenderingContext and make it state-full as well, removing the hacks currently needed for "currentContentTransformation" and fixing up the design in general.