Bug 81890 - Merge SVGImageBufferTools to SVGRenderingContext
Summary: Merge SVGImageBufferTools to SVGRenderingContext
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Nobody
Depends on:
Reported: 2012-03-22 04:17 PDT by Zoltan Herczeg
Modified: 2012-03-23 01:50 PDT (History)
4 users (show)

See Also:

patch (44.81 KB, patch)
2012-03-22 04:28 PDT, Zoltan Herczeg
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2012-03-22 04:17:42 PDT
Copy the methods, no functionality change.
Comment 1 Zoltan Herczeg 2012-03-22 04:28:14 PDT
Created attachment 133221 [details]
Comment 2 Nikolas Zimmermann 2012-03-22 05:22:54 PDT
Comment on attachment 133221 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=133221&action=review

Looks great, r=me, in case cr-linux ews bot is also happy with it.

> Source/WebCore/ChangeLog:11
> +        no functionality change.
> +

You should note here, that this is the first step, towards making SVGImageBufferTools stageful, and this only moves the code.
Comment 3 Zoltan Herczeg 2012-03-22 05:52:58 PDT
Thanks for the review. Landed as http://trac.webkit.org/changeset/111674
Comment 4 Dirk Schulze 2012-03-22 11:02:15 PDT
I'm not opposed to the change, but what is the reason for moving it?
Comment 5 Nikolas Zimmermann 2012-03-23 01:50:54 PDT
(In reply to comment #4)
> I'm not opposed to the change, but what is the reason for moving it?
Sorry for not including more context here, I discuss this since a while with Zoltan.
The goal is to change the current state-less design of SVGImageBufferTools/SVGRenderingSupport. As first step Zoltan extracted the prepareRenderSVGContent/finishREnderSVGContent from SVGRenderSupport into SVGRenderingContext, making it state-full (not a bunch of static functions, but a real class holding data). This simplifies the SVG subtree rendering code a lot.

SVGImageBufferTools suffers from the same problem. The intent is to merge it into SVGRenderingContext and make it state-full as well, removing the hacks currently needed for "currentContentTransformation" and fixing up the design in general.