Bug 81887 - [BlackBerry] add interface clearCredentials() and clearNeverRememberSites()
Summary: [BlackBerry] add interface clearCredentials() and clearNeverRememberSites()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 03:19 PDT by Jonathan Dong
Modified: 2012-03-22 19:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.35 KB, patch)
2012-03-22 03:33 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff
Patch (6.32 KB, patch)
2012-03-22 06:01 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-03-22 03:19:40 PDT
add interface function clearCredentials() and clearNeverRememberSites() into class WebPage, and implements its corresponding functions.
Comment 1 Jonathan Dong 2012-03-22 03:33:01 PDT
Created attachment 133213 [details]
Patch
Comment 2 Rob Buis 2012-03-22 04:25:09 PDT
Comment on attachment 133213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133213&action=review

Looks good, but please fix typos and then let Charles or Leo cq+ or land for you.

> Source/WebCore/ChangeLog:8
> +        Fixed SQL issue when clear table logins and table never_remember.

when clearing

> Source/WebKit/blackberry/ChangeLog:12
> +        Also implemented the corresponding funcions in class

functions.

> Source/WebKit/blackberry/ChangeLog:14
> +        to perform the actuall clear table work.

actual
Comment 3 Jonathan Dong 2012-03-22 06:01:01 PDT
Created attachment 133239 [details]
Patch
Comment 4 Rob Buis 2012-03-22 19:19:03 PDT
Comment on attachment 133239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133239&action=review

Looks good.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:418
> +    HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE FROM never_remember"),

never_remember sounds like it can be improved upon, maybe an english native speaker has a suggestion, will ask in the office.
Comment 5 WebKit Review Bot 2012-03-22 19:26:28 PDT
Comment on attachment 133239 [details]
Patch

Clearing flags on attachment: 133239

Committed r111811: <http://trac.webkit.org/changeset/111811>
Comment 6 WebKit Review Bot 2012-03-22 19:26:42 PDT
All reviewed patches have been landed.  Closing bug.