Bug 81887 – [BlackBerry] add interface clearCredentials() and clearNeverRememberSites()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Jonathan Dong]

add interface function clearCredentials() and clearNeverRememberSites() into class WebPage, and implements its corresponding functions.

[Jonathan Dong]

Created attachment 133213 [details]
Patch

[Rob Buis]

Comment on attachment 133213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133213&action=review

Looks good, but please fix typos and then let Charles or Leo cq+ or land for you.

> Source/WebCore/ChangeLog:8
> +        Fixed SQL issue when clear table logins and table never_remember.

when clearing

> Source/WebKit/blackberry/ChangeLog:12
> +        Also implemented the corresponding funcions in class

functions.

> Source/WebKit/blackberry/ChangeLog:14
> +        to perform the actuall clear table work.

actual

[Jonathan Dong]

Created attachment 133239 [details]
Patch

[Rob Buis]

Comment on attachment 133239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133239&action=review

Looks good.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:418
> +    HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE FROM never_remember"),

never_remember sounds like it can be improved upon, maybe an english native speaker has a suggestion, will ask in the office.

[WebKit Review Bot]

Comment on attachment 133239 [details]
Patch

Clearing flags on attachment: 133239

Committed r111811: <http://trac.webkit.org/changeset/111811>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.