Bug 81886 - [Gtk] Compilation fails if RequestAnimationFrame feature is disabled after r110185
Summary: [Gtk] Compilation fails if RequestAnimationFrame feature is disabled after r1...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 03:09 PDT by Zan Dobersek
Modified: 2013-03-18 13:01 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-03-22 03:09:48 PDT 
Compilation fails in ScrollAnimatorNone.h[1] if RequestAnimationFrame feature is disabled.
This started to occur after r110185[2].

A few ways of fixing this
- set ENABLE_SCROLL_ANIMATOR=1 in GNUmakefile.am only if RequestAnimationFrame feature is enabled
- refactor some of the WebCore code to always provide either a DisplayRefreshMonitor if provided or a fallback timer implementation.

[1] http://trac.webkit.org/browser/trunk/Source/WebCore/platform/ScrollAnimatorNone.h#L37
[2] http://trac.webkit.org/changeset/110185
Comment 1 Zan Dobersek 2013-03-18 13:01:33 PDT 
The feature enabling is now rigid enough to not allow disabling the requestAnimationFrame feature support. Closing this as WONTFIX.