Bug 81866 – Expand RenderTextControlSingleLine::controlClipRect() to contain contentRect().

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Clip by contentRect() instead of container's frameRect() in RenderTextControlSingleLine

[Kent Tamura]

Created attachment 133189 [details]
Patch

[Kent Tamura]

Comment on attachment 133189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133189&action=review

> Source/WebCore/ChangeLog:28
> +          â ShadowRoot
> +             â container element
> +        âââââââââââââââ<input> box
> +        â ââââââââââââ â
> +        â âcontainer box       â â
> +        â ââââââââââââ â
> +        âââââââââââââââ

Broken by Bug 75394.  Please look at https://bugs.webkit.org/attachment.cgi?id=133189 instead.

[Hajime Morrita]

Comment on attachment 133189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133189&action=review

Do we really need to handle searchbox specially?
can be just compute union of content element and clip?

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:375
> +        RenderBox* containerBox = containerElement()->renderBox();

It looks we can expect containerbox being not null according to the original code?

[Kent Tamura]

(In reply to comment #3)
> Do we really need to handle searchbox specially?
> can be just compute union of content element and clip?

Oh, union is a good idea.

[Kent Tamura]

Created attachment 133197 [details]
Patch 2

[WebKit Review Bot]

Comment on attachment 133197 [details]
Patch 2

Clearing flags on attachment: 133197

Committed r111660: <http://trac.webkit.org/changeset/111660>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.