Bug 81859 – Chromium: Should enable -webkit-image-set

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Beth Dakin]

https://bugs.webkit.org/show_bug.cgi?id=80322 adds a new CSS property called -webkit-image-set. Since the implementation is currently incomplete, ports have to opt-in. Chrome should decide when to opt in.

[Robert Flack]

Created attachment 136710 [details]
Patch

[WebKit Review Bot]

Attachment 136710 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Robert Kroeger]

Comment on attachment 136710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136710&action=review

change looks good. add the image expectations

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

you must change this line. it will not pass the commit queue.

[WebKit Review Bot]

Comment on attachment 136710 [details]
Patch

Attachment 136710 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12387257

New failing tests:
fast/css/image-set-parsing.html

[WebKit Review Bot]

Created attachment 136743 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[WebKit Review Bot]

Comment on attachment 136710 [details]
Patch

Attachment 136710 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12392020

New failing tests:
fast/css/image-set-parsing.html

[WebKit Review Bot]

Created attachment 136759 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Robert Flack]

Created attachment 136919 [details]
Patch

[WebKit Review Bot]

Comment on attachment 136919 [details]
Patch

Attachment 136919 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12392491

New failing tests:
fast/css/image-set-parsing.html

[WebKit Review Bot]

Created attachment 136933 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Robert Flack]

Created attachment 136979 [details]
Patch

[Adam Barth]

Comment on attachment 136979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136979&action=review

> LayoutTests/platform/chromium/fast/css/image-set-parsing-expected.txt:58
> +FAIL jsWrapperClass(imageSetRule.__proto__) should be CSSValueListPrototype. Was Object.
> +FAIL jsWrapperClass(imageSetRule.constructor) should be CSSValueListConstructor. Was Function.

Why do we fail these subtests?

[Robert Flack]

(In reply to comment #12)
> (From update of attachment 136979 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136979&action=review
> 
> > LayoutTests/platform/chromium/fast/css/image-set-parsing-expected.txt:58
> > +FAIL jsWrapperClass(imageSetRule.__proto__) should be CSSValueListPrototype. Was Object.
> > +FAIL jsWrapperClass(imageSetRule.constructor) should be CSSValueListConstructor. Was Function.
> 
> Why do we fail these subtests?

It seems we do this for all the chromium tests which use toString to verify the class prototype and constructor since chromium always returns Object and Function for these respectively. For example for the prototype:  
egrep --exclude-dir=".svn" -r "jsWrapperClass\(.*.__proto__\) should be [A-Za-z]*\. Was Object\." . |wc -l
155

[Adam Barth]

Comment on attachment 136979 [details]
Patch

Interesting.  I wonder when that started.

[WebKit Review Bot]

Comment on attachment 136979 [details]
Patch

Clearing flags on attachment: 136979

Committed r114140: <http://trac.webkit.org/changeset/114140>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Vincent Scheib]

I rolled this out. Layout test was failing, 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=fast%2Fcss%2Fimage-set-parsing.html

[Robert Flack]

Relanded in http://trac.webkit.org/changeset/114163. The features.gypi change required clobbering the windows chromium bots. I don't think I have permission to close the issue.

[Adam Barth]

Robert, if you ask eseidel in #webkit, he should be able to give you the EditBugs permission.