Bug 81858 – Enable layout testing of the scroll animator.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Scott Byer]

Enable layout testing of the scroll animator.

[Scott Byer]

Created attachment 133159 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Scott Byer]

James, if you get a chance, could you take a look? Robert and I decided that crbug.com/118507 isn't critical for m19, so if you're slammed with other m19 things, this can wait.

[James Robinson]

Comment on attachment 133159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133159&action=review

Public WK API changes look fine. I'm not as familiar with how InternalSettings are supposed to work, so perhaps someone who's more familiar with that logic would be able to review. I don't think this is critical for M19 and I'm semi-unavailable.

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:769
> +    postDelayedTask(new HostMethodTask(this, &WebViewHost::serviceAnimation), 0);

Hm, I'm a bit surprised that this didn't have any impact on the fast/animation/ tests.

[James Robinson]

Comment on attachment 133159 [details]
Patch

R=me assuming it actually is a no-op (and doesn't break fast/animations)

[WebKit Review Bot]

Comment on attachment 133159 [details]
Patch

Clearing flags on attachment: 133159

Committed r112196: <http://trac.webkit.org/changeset/112196>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tony Chang]

Did we ever write any layout tests that use internals.settings.setEnableScrollAnimator/scrollAnimatorEnabled?  I don't see any calls to these methods in LayoutTests and was wondering if I could remove these methods.