Bug 81858 - Enable layout testing of the scroll animator.
Summary: Enable layout testing of the scroll animator.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Scott Byer
URL:
Keywords:
Depends on:
Blocks: 81436
  Show dependency tree / graph
 
Reported: 2012-03-21 18:15 PDT by Scott Byer
Modified: 2013-03-21 16:31 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.30 KB, patch)
2012-03-21 18:22 PDT, Scott Byer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Byer 2012-03-21 18:15:00 PDT 
Enable layout testing of the scroll animator.
Comment 1 Scott Byer 2012-03-21 18:22:13 PDT 
Created attachment 133159 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-21 18:24:24 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Scott Byer 2012-03-22 16:46:00 PDT 
James, if you get a chance, could you take a look? Robert and I decided that crbug.com/118507 isn't critical for m19, so if you're slammed with other m19 things, this can wait.
Comment 4 James Robinson 2012-03-23 09:16:28 PDT 
Comment on attachment 133159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133159&action=review

Public WK API changes look fine. I'm not as familiar with how InternalSettings are supposed to work, so perhaps someone who's more familiar with that logic would be able to review. I don't think this is critical for M19 and I'm semi-unavailable.

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:769
> +    postDelayedTask(new HostMethodTask(this, &WebViewHost::serviceAnimation), 0);

Hm, I'm a bit surprised that this didn't have any impact on the fast/animation/ tests.
Comment 5 James Robinson 2012-03-26 18:33:03 PDT 
Comment on attachment 133159 [details]
Patch

R=me assuming it actually is a no-op (and doesn't break fast/animations)
Comment 6 WebKit Review Bot 2012-03-26 19:41:37 PDT 
Comment on attachment 133159 [details]
Patch

Clearing flags on attachment: 133159

Committed r112196: <http://trac.webkit.org/changeset/112196>
Comment 7 WebKit Review Bot 2012-03-26 19:41:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Tony Chang 2013-03-21 16:31:03 PDT 
Did we ever write any layout tests that use internals.settings.setEnableScrollAnimator/scrollAnimatorEnabled?  I don't see any calls to these methods in LayoutTests and was wondering if I could remove these methods.