RESOLVED FIXED Bug 81850
MathML internals - improve naming in RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp 
https://bugs.webkit.org/show_bug.cgi?id=81850
Summary MathML internals - improve naming in RenderMathMLSquareRoot.cpp and RenderMat...
Dave Barton
Reported 2012-03-21 17:30:13 PDT
MathML internals - improve naming in RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp
Attachments
Patch (25.70 KB, patch)
2012-03-21 17:39 PDT, Dave Barton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Barton
Comment 1 2012-03-21 17:39:00 PDT
Created attachment 133155 [details] Patch
Eric Seidel (no email)
Comment 2 2012-03-21 17:51:19 PDT
Comment on attachment 133155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133155&action=review LGTM. > Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:82 > + baseWrapper->style()->setPaddingLeft(Length(5 * gFrontWidthEms, Percent)); Thank you for documenting the type of the unit in name of the variable, very helpful!
WebKit Review Bot
Comment 3 2012-03-21 18:33:50 PDT
Comment on attachment 133155 [details] Patch Clearing flags on attachment: 133155 Committed r111636: <http://trac.webkit.org/changeset/111636>
WebKit Review Bot
Comment 4 2012-03-21 18:33:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.