Bug 81840 - DFG speculation on booleans should be rationalized
Summary: DFG speculation on booleans should be rationalized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-21 15:52 PDT by Filip Pizlo
Modified: 2012-03-21 20:48 PDT (History)
0 users

See Also:


Attachments
the patch (13.61 KB, patch)
2012-03-21 16:32 PDT, Filip Pizlo
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-03-21 15:52:35 PDT
Right now there is a bit of a mess of calls to isKnownBoolean() for some code paths and shouldSpeculateBoolean() for others. From the standpoint of trying to reason about the types of nodes, we should stick to using shouldSpeculateBoolean() as the main guard, which secondary guards based on AbstractState to determine if the boolean checks have already been performed.
Comment 1 Filip Pizlo 2012-03-21 16:32:30 PDT
Created attachment 133141 [details]
the patch
Comment 2 Filip Pizlo 2012-03-21 20:48:18 PDT
Landed in http://trac.webkit.org/changeset/111649