WTF::MetaAllocator has a weak vtable (discovered when building wtf as a static library)
Created attachment 133127 [details] Patch
Comment on attachment 133127 [details] Patch r=me
(This patch won't actually apply to trunk, since it is on top of a local commit with the WTF files already moved to their new location.)
Comment on attachment 133127 [details] Patch Rejecting attachment 133127 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: file Source/WTF/ChangeLog patching file Source/WTF/wtf/MetaAllocator.cpp Hunk #1 FAILED at 33. 1 out of 1 hunk FAILED -- saving rejects to file Source/WTF/wtf/MetaAllocator.cpp.rej patching file Source/WTF/wtf/MetaAllocator.h Hunk #1 FAILED at 196. 1 out of 1 hunk FAILED -- saving rejects to file Source/WTF/wtf/MetaAllocator.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Geoffrey G..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12072618
Created attachment 133134 [details] Patch for landing
Comment on attachment 133134 [details] Patch for landing Rejecting attachment 133134 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: hing file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/wtf/MetaAllocator.cpp Hunk #1 succeeded at 47 with fuzz 2 (offset 14 lines). patching file Source/JavaScriptCore/wtf/MetaAllocator.h Hunk #1 FAILED at 196. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/wtf/MetaAllocator.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12066681
Landed in http://trac.webkit.org/changeset/111617.
(In reply to comment #7) > Landed in http://trac.webkit.org/changeset/111617. This change broke the TestWebKitAPI build. Two symbols are no longer exported: WTF::MetaAllocator::~MetaAllocator() and typeinfo for WTF::MetaAllocator I can export the former by adding WTF_EXPORT_PRIVATE before its declaration in the header, but I don’t know how to export the latter.
(In reply to comment #8) > (In reply to comment #7) > > Landed in http://trac.webkit.org/changeset/111617. > > This change broke the TestWebKitAPI build. Two symbols are no longer exported: > > WTF::MetaAllocator::~MetaAllocator() > > and > > typeinfo for WTF::MetaAllocator > > I can export the former by adding WTF_EXPORT_PRIVATE before its declaration in the header, but I don’t know how to export the latter. Probably WTF_EXPORTCLASS? I dont' actually know.
The WTF/JSC exports are really a mistery to me, I'm currently runnig into issues tryign to bring up the JSC build after moving WTF locally due to our current export config.
(In reply to comment #8) > (In reply to comment #7) > > Landed in http://trac.webkit.org/changeset/111617. > > This change broke the TestWebKitAPI build. Two symbols are no longer exported: I assume I can test this locally on mac using "make"?
(In reply to comment #11) > (In reply to comment #8) > > (In reply to comment #7) > > > Landed in http://trac.webkit.org/changeset/111617. > > > > This change broke the TestWebKitAPI build. Two symbols are no longer exported: > > I assume I can test this locally on mac using "make"? Yes. If you can’t find out how to fix this soon, please revert r111617, so that tests can run again.
(In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #8) > > > (In reply to comment #7) > > > > Landed in http://trac.webkit.org/changeset/111617. > > > > > > This change broke the TestWebKitAPI build. Two symbols are no longer exported: > > > > I assume I can test this locally on mac using "make"? > > Yes. If you can’t find out how to fix this soon, please revert r111617, so that tests can run again. Certainly. I'm running "make" now.
(In reply to comment #11) > (In reply to comment #8) > > (In reply to comment #7) > > > Landed in http://trac.webkit.org/changeset/111617. > > > > This change broke the TestWebKitAPI build. Two symbols are no longer exported: > > I assume I can test this locally on mac using "make"? Hmm. "make" resulted in: ** BUILD SUCCEEDED ** for me. I guess I"ll try again with a clean build?
I fixed the problems in r111634.
Thank you. I just got a reproduction. :)