Bug 81820 - Rename touchpad fling curve, add curve parameters to constructor.
Summary: Rename touchpad fling curve, add curve parameters to constructor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: W. James MacLean
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-21 12:07 PDT by W. James MacLean
Modified: 2012-03-22 07:03 PDT (History)
8 users (show)

See Also:

Attachments
Patch (21.40 KB, patch)
2012-03-21 12:09 PDT, W. James MacLean 		no flags Details | Formatted Diff | Diff
Patch (22.25 KB, patch)
2012-03-21 12:40 PDT, W. James MacLean 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description W. James MacLean 2012-03-21 12:07:37 PDT 
Rename touchpad fling curve, add curve parameters to constructor.
Comment 1 W. James MacLean 2012-03-21 12:09:19 PDT 
Created attachment 133089 [details]
Patch
Comment 2 Philippe Normand 2012-03-21 12:17:39 PDT 
Comment on attachment 133089 [details]
Patch

Attachment 133089 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12035638
Comment 3 W. James MacLean 2012-03-21 12:40:31 PDT 
Created attachment 133098 [details]
Patch
Comment 4 W. James MacLean 2012-03-21 12:40:56 PDT 
Patch to update GTK make files.
Comment 5 Adrienne Walker 2012-03-21 14:07:49 PDT 
It's really hard to read a diff when you both rename a file and change the implementation.  I realize you're trying to move quickly here, but that's not helping.
Comment 6 W. James MacLean 2012-03-21 14:26:55 PDT 
(In reply to comment #5)
> It's really hard to read a diff when you both rename a file and change the implementation.  I realize you're trying to move quickly here, but that's not helping.

Sorry about that ... I hadn't quite realized how the diffs would turn out until after I uploaded the patch (git shows things more sensibly ...).

Should I re-do them separately?
Comment 7 Adrienne Walker 2012-03-21 14:36:35 PDT 
Comment on attachment 133098 [details]
Patch

No, don't bother.  I've looked at it enough now that I see what's going on.  Along with renaming a file, it just looks like you're removing a static (yay) and moving it to be a member variable that you can also now set from the constructor.  Seems totally reasonable.
Comment 8 W. James MacLean 2012-03-22 05:59:24 PDT 
(In reply to comment #7)
> (From update of attachment 133098 [details])
> No, don't bother.  I've looked at it enough now that I see what's going on.  Along with renaming a file, it just looks like you're removing a static (yay) and moving it to be a member variable that you can also now set from the constructor.  Seems totally reasonable.

Thanks - I'll make sure not do combine a rename op with anything else in future :-)
Comment 9 WebKit Review Bot 2012-03-22 07:03:24 PDT 
Comment on attachment 133098 [details]
Patch

Clearing flags on attachment: 133098

Committed r111686: <http://trac.webkit.org/changeset/111686>
Comment 10 WebKit Review Bot 2012-03-22 07:03:29 PDT 
All reviewed patches have been landed.  Closing bug.