Bug 81812 – garden-o-matic should special case reftests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ojan Vafai]

Reftests should:
-not have a rebaseline button
-Show somehow that they are reftests
-Show the output of the test, the reference and the diff

[Adam Barth]

I don't plan to implement this feature any time soon, but other folks should feel free to.

[Ojan Vafai]

Created attachment 133886 [details]
Patch

[Ojan Vafai]

Comment on attachment 133886 [details]
Patch

Whoops. Forgot to add test.

[Ojan Vafai]

Created attachment 133890 [details]
Patch

[Adam Barth]

Comment on attachment 133890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133890&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:177
> +    for (var builder in results) {

We've been using forEach rather than loops.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:203
> +                $(header).append('<div class="non-action-button">Reftest cannot be rebaselined</div>');

What is the gardener supposed to do in this case?  Can we provide some help text?

[Ojan Vafai]

(In reply to comment #5)
> (From update of attachment 133890 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133890&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:203
> > +                $(header).append('<div class="non-action-button">Reftest cannot be rebaselined</div>');
> 
> What is the gardener supposed to do in this case?  Can we provide some help text?

I'm not really sure. Don't have enough experience with reftests to understand what the common pitfalls/solutions are. Open to suggestions.

[Adam Barth]

> I'm not really sure. Don't have enough experience with reftests to understand what the common pitfalls/solutions are. Open to suggestions.

Maybe we should say that?  We could encourage folks to who run into these situations to email the gardening lists with thoughts about what we should do in these cases.

[Ojan Vafai]

Committed r112149: <http://trac.webkit.org/changeset/112149>