Bug 81775 - Correct LayoutUnit usage in VisiblePosition.cpp
Summary: Correct LayoutUnit usage in VisiblePosition.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-03-21 06:29 PDT by Levi Weintraub
Modified: 2012-03-21 15:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.50 KB, patch)
2012-03-21 06:46 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-03-21 06:29:19 PDT 
There's currently a mismatched function definition, and we assign localCaretRect to an IntRect, when local coordinates should be LayoutUnits.
Comment 1 Levi Weintraub 2012-03-21 06:46:04 PDT 
Created attachment 133035 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-03-21 11:15:07 PDT 
Comment on attachment 133035 [details]
Patch

OK.  Caret rects will be sub-pixel precise?
Comment 3 Levi Weintraub 2012-03-21 15:32:37 PDT 
Comment on attachment 133035 [details]
Patch

Thanks Eric :)
Comment 4 WebKit Review Bot 2012-03-21 15:42:42 PDT 
Comment on attachment 133035 [details]
Patch

Clearing flags on attachment: 133035

Committed r111613: <http://trac.webkit.org/changeset/111613>
Comment 5 WebKit Review Bot 2012-03-21 15:42:46 PDT 
All reviewed patches have been landed.  Closing bug.