RESOLVED FIXED Bug 81766
Web Inspector: get rid of isInEditMode, use isBeingEdited on particular element. 
https://bugs.webkit.org/show_bug.cgi?id=81766
Summary Web Inspector: get rid of isInEditMode, use isBeingEdited on particular element.
Pavel Feldman
Reported 2012-03-21 05:22:38 PDT
We should check even target and its ancestors for being edited, not use some global property.
Attachments
Patch (47.70 KB, patch)
2012-03-21 05:59 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-03-21 05:59:29 PDT
Created attachment 133026 [details] Patch
Yury Semikhatsky
Comment 2 2012-03-21 09:24:12 PDT
Comment on attachment 133026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133026&action=review > Source/WebCore/ChangeLog:8 > + We should check even target and its ancestors for being edited, not use some even -> event > Source/WebCore/inspector/front-end/UIUtils.js:192 > + while (element && element.nodeType === Node.ELEMENT_NODE) { Instead of element.nodeType === Node.ELEMENT_NODE you can just use element.parentElement below. > Source/WebCore/inspector/front-end/utilities.js:381 > + this.stopImmediatePropagation(); It was stopPropagation, are you sure this change won't break any listener?
Pavel Feldman
Comment 3 2012-03-21 09:28:46 PDT
> even -> event Done. > > Instead of element.nodeType === Node.ELEMENT_NODE you can just use element.parentElement below. > Done. > > Source/WebCore/inspector/front-end/utilities.js:381 > > + this.stopImmediatePropagation(); > > It was stopPropagation, are you sure this change won't break any listener? stopImmediatePropagation implies stopPropagation, so it should work.
Pavel Feldman
Comment 4 2012-03-21 09:33:28 PDT
Committed r111551: <http://trac.webkit.org/changeset/111551>
Note You need to log in before you can comment on or make changes to this bug.