WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81746
REGRESSION (
r111497
): fast/css/text-transform-select.html and fast/forms/select/menulist-disabled-option.html is failing
https://bugs.webkit.org/show_bug.cgi?id=81746
Summary
REGRESSION (r111497): fast/css/text-transform-select.html and fast/forms/sele...
mitz
Reported
2012-03-21 00:50:25 PDT
After <
http://trac.webkit.org/r111500
>, text-transform is not applied to the popup button text in fast/css/text-transform-select.html.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2012-03-21 00:50:53 PDT
<
rdar://problem/11088942
>
mitz
Comment 2
2012-03-21 01:04:33 PDT
Updated the Mac expected results for this test in <
http://trac.webkit.org/r111508
>.
Csaba Osztrogonác
Comment 3
2012-03-21 06:11:31 PDT
r111497
is the culprit, not
r111500
. -
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r111527%20%2835221%29/fast/css/text-transform-select-pretty-diff.html
-
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r111527%20%2835221%29/fast/forms/select/menulist-disabled-option-diffs.html
These tests fail on Qt,GTK, Chromium too. GTK guys landed failing expected result for it -
http://trac.webkit.org/changeset/111513/trunk/LayoutTests/platform/gtk/fast/css/text-transform-select-expected.txt
and Chromium guys did it too -
http://trac.webkit.org/changeset/111506
Csaba Osztrogonác
Comment 4
2012-03-21 06:16:05 PDT
Just a question: Why don't we simple rollout
r111497
and let the author fix the regression caused by his patch? We make extra work for us if we commit failing expected files, skip failing tests, etc.
Csaba Osztrogonác
Comment 5
2012-03-21 06:40:03 PDT
(In reply to
comment #4
)
> Just a question: Why don't we simple rollout
r111497
and let the author fix the regression caused by his patch? We make extra work for us if we commit failing expected files, skip failing tests, etc.
Rolled out with gardenings too -
http://trac.webkit.org/changeset/111532
. (rs=Philipp)
mitz
Comment 6
2012-03-21 07:20:29 PDT
(In reply to
comment #5
)
> (In reply to
comment #4
) > > Just a question: Why don't we simple rollout
r111497
and let the author fix the regression caused by his patch? We make extra work for us if we commit failing expected files, skip failing tests, etc. > > Rolled out with gardenings too -
http://trac.webkit.org/changeset/111532
. (rs=Philipp)
Thanks. Is there a reason why you didn’t change this bug’s status to Resolved?
Csaba Osztrogonác
Comment 7
2012-03-21 07:21:22 PDT
(In reply to
comment #6
)
> (In reply to
comment #5
) > > (In reply to
comment #4
) > > > Just a question: Why don't we simple rollout
r111497
and let the author fix the regression caused by his patch? We make extra work for us if we commit failing expected files, skip failing tests, etc. > > > > Rolled out with gardenings too -
http://trac.webkit.org/changeset/111532
. (rs=Philipp) > > Thanks. Is there a reason why you didn’t change this bug’s status to Resolved?
Yes, I forgot it. :)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug