Bug 81730 - [chromium] Use origin transform to transform occlusion from surface content space to its target content space
Summary: [chromium] Use origin transform to transform occlusion from surface content s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 20:20 PDT by Dana Jansens
Modified: 2012-03-20 22:29 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.42 KB, patch)
2012-03-20 20:27 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch (7.64 KB, patch)
2012-03-20 21:23 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-03-20 20:20:37 PDT 
[chromium] Use origin transform to transform occlusion from surface content space to its target content space
Comment 1 Dana Jansens 2012-03-20 20:27:44 PDT 
I was doing some weird mojo to use the surface draw transform, which is centered in the surface clip rect. Anyhow it was lot of nonsense based in my misunderstandings. All I needed to do was use the origin transform!
Comment 2 Dana Jansens 2012-03-20 20:27:51 PDT 
Created attachment 132955 [details]
Patch
Comment 3 Dana Jansens 2012-03-20 20:28:21 PDT 
This fixes android.com
Comment 4 Dana Jansens 2012-03-20 20:53:52 PDT 
Comment on attachment 132955 [details]
Patch

Oops broken unit test
Comment 5 WebKit Review Bot 2012-03-20 21:10:24 PDT 
Comment on attachment 132955 [details]
Patch

Attachment 132955 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12066165
Comment 6 Dana Jansens 2012-03-20 21:23:14 PDT 
Created attachment 132965 [details]
Patch

Fixed unit test
Comment 7 Adrienne Walker 2012-03-20 21:55:55 PDT 
Comment on attachment 132965 [details]
Patch

The new code looks way better.  R=me.
Comment 8 WebKit Review Bot 2012-03-20 22:29:15 PDT 
Comment on attachment 132965 [details]
Patch

Clearing flags on attachment: 132965

Committed r111502: <http://trac.webkit.org/changeset/111502>
Comment 9 WebKit Review Bot 2012-03-20 22:29:21 PDT 
All reviewed patches have been landed.  Closing bug.