Bug 81728 - Stop keeping a frame tree in the UIProcess
Summary: Stop keeping a frame tree in the UIProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 19:58 PDT by Sam Weinig
Modified: 2013-02-03 19:13 PST (History)
2 users (show)

See Also:

Attachments
Patch (15.01 KB, patch)
2012-03-20 20:00 PDT, Sam Weinig 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-03-20 19:58:24 PDT 
Stop keeping a frame tree in the UIProcess
Comment 1 Sam Weinig 2012-03-20 20:00:40 PDT 
Created attachment 132952 [details]
Patch
Comment 2 Oliver Hunt 2012-03-24 12:12:30 PDT 
Comment on attachment 132952 [details]
Patch

r=me
Comment 3 Alexey Proskuryakov 2012-12-18 11:28:14 PST 
Sam, has this patch been landed?
Comment 4 Sam Weinig 2012-12-18 14:12:24 PST 
Alas, it did not.  But should!
Comment 5 Sam Weinig 2013-02-02 15:51:42 PST 
Committed r141708: <http://trac.webkit.org/changeset/141708>
Comment 6 Simon Fraser (smfr) 2013-02-02 19:23:17 PST 
This may have caused an API test to start failing:

Note: Google Test filter = WebKit2.ShouldGoToBackForwardListItem
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from WebKit2
[ RUN      ] WebKit2.ShouldGoToBackForwardListItem
/Volumes/Data/slave/mountainlion-debug/build/Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:89: Failure
Value of: true
Expected: receivedProperBackForwardCallbacks
Which is: false
[  FAILED  ] WebKit2.ShouldGoToBackForwardListItem (508 ms)
Comment 7 Sam Weinig 2013-02-03 19:07:47 PST 
(In reply to comment #6)
> This may have caused an API test to start failing:
> 
> Note: Google Test filter = WebKit2.ShouldGoToBackForwardListItem
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from WebKit2
> [ RUN      ] WebKit2.ShouldGoToBackForwardListItem
> /Volumes/Data/slave/mountainlion-debug/build/Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:89: Failure
> Value of: true
> Expected: receivedProperBackForwardCallbacks
> Which is: false
> [  FAILED  ] WebKit2.ShouldGoToBackForwardListItem (508 ms)

Indeed.  Easy to fix.
Comment 8 Sam Weinig 2013-02-03 19:13:03 PST 
(In reply to comment #7)
> (In reply to comment #6)
> > This may have caused an API test to start failing:
> > 
> > Note: Google Test filter = WebKit2.ShouldGoToBackForwardListItem
> > [==========] Running 1 test from 1 test case.
> > [----------] Global test environment set-up.
> > [----------] 1 test from WebKit2
> > [ RUN      ] WebKit2.ShouldGoToBackForwardListItem
> > /Volumes/Data/slave/mountainlion-debug/build/Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:89: Failure
> > Value of: true
> > Expected: receivedProperBackForwardCallbacks
> > Which is: false
> > [  FAILED  ] WebKit2.ShouldGoToBackForwardListItem (508 ms)
> 
> Indeed.  Easy to fix.

Fixed in r141729.