RESOLVED FIXED 81728
Stop keeping a frame tree in the UIProcess 
https://bugs.webkit.org/show_bug.cgi?id=81728
Summary Stop keeping a frame tree in the UIProcess
Sam Weinig
Reported 2012-03-20 19:58:24 PDT
Stop keeping a frame tree in the UIProcess
Attachments
Patch (15.01 KB, patch)
2012-03-20 20:00 PDT, Sam Weinig 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-03-20 20:00:40 PDT
Created attachment 132952 [details] Patch
Oliver Hunt
Comment 2 2012-03-24 12:12:30 PDT
Comment on attachment 132952 [details] Patch r=me
Alexey Proskuryakov
Comment 3 2012-12-18 11:28:14 PST
Sam, has this patch been landed?
Sam Weinig
Comment 4 2012-12-18 14:12:24 PST
Alas, it did not. But should!
Sam Weinig
Comment 5 2013-02-02 15:51:42 PST
Committed r141708: <http://trac.webkit.org/changeset/141708>
Simon Fraser (smfr)
Comment 6 2013-02-02 19:23:17 PST
This may have caused an API test to start failing: Note: Google Test filter = WebKit2.ShouldGoToBackForwardListItem [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WebKit2 [ RUN ] WebKit2.ShouldGoToBackForwardListItem /Volumes/Data/slave/mountainlion-debug/build/Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:89: Failure Value of: true Expected: receivedProperBackForwardCallbacks Which is: false [ FAILED ] WebKit2.ShouldGoToBackForwardListItem (508 ms)
Sam Weinig
Comment 7 2013-02-03 19:07:47 PST
(In reply to comment #6) > This may have caused an API test to start failing: > > Note: Google Test filter = WebKit2.ShouldGoToBackForwardListItem > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from WebKit2 > [ RUN ] WebKit2.ShouldGoToBackForwardListItem > /Volumes/Data/slave/mountainlion-debug/build/Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:89: Failure > Value of: true > Expected: receivedProperBackForwardCallbacks > Which is: false > [ FAILED ] WebKit2.ShouldGoToBackForwardListItem (508 ms) Indeed. Easy to fix.
Sam Weinig
Comment 8 2013-02-03 19:13:03 PST
(In reply to comment #7) > (In reply to comment #6) > > This may have caused an API test to start failing: > > > > Note: Google Test filter = WebKit2.ShouldGoToBackForwardListItem > > [==========] Running 1 test from 1 test case. > > [----------] Global test environment set-up. > > [----------] 1 test from WebKit2 > > [ RUN ] WebKit2.ShouldGoToBackForwardListItem > > /Volumes/Data/slave/mountainlion-debug/build/Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:89: Failure > > Value of: true > > Expected: receivedProperBackForwardCallbacks > > Which is: false > > [ FAILED ] WebKit2.ShouldGoToBackForwardListItem (508 ms) > > Indeed. Easy to fix. Fixed in r141729.
Note You need to log in before you can comment on or make changes to this bug.